-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix wasm toolchain #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wasm toolchain #2531
Conversation
I think this is along the correct path for the fix, but this specific iteration ends up hitting this error when trying to generate the boiler plate code:
|
@LoopedBard3 Hm, well I'm not sure about that issue. Can you take over from here? It's hard for me to do anything without being able to run it. |
I am still trying out some things. I will keep the main tracking issue updated with any findings and what not 👍. |
I believe adding |
I've made a PR to add an integration test which should help with local testing, you need to have the wasm-tools workload installed ( |
Yeah, that's the part I got stuck on on my Windows machine. 😞 |
@LoopedBard3 Does that change make it work? |
I did get a successful local run with the branch for the PR caaavik put up: #2532 |
Update wasmcsproj template.
3597769
to
070b2bc
Compare
This ran successfully with a local wasm wasm test run. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timcassell thanks a lot! LGTM!
I think this should fix dotnet/performance#3984, but I couldn't get wasm to work locally, so I couldn't test it. PTAL @LoopedBard3