Skip to content

[wasm] Rename module file to .mjs #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mkhamoyan
Copy link

Rename test-main.js to test-main.mjs

@ilonatommy
Copy link
Member

/azp run runtime-wasm

Copy link

Commenter does not have sufficient privileges for PR 2597 in repo dotnet/BenchmarkDotNet

@adamsitnik
Copy link
Member

/azp run runtime-wasm

This should not be required, as the WASM test added by @caaavik-msft in #2532 should be just always executed.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why is this file being renamed again? What do we get from it?

@mkhamoyan
Copy link
Author

May I ask why is this file being renamed again? What do we get from it?

The test-main.js file was updated to require the --module flag. Renaming the file to .mjs helps clarify that it is a JavaScript module.

@timcassell
Copy link
Collaborator

cc @radical Looks similar to #2345.

@mkhamoyan
Copy link
Author

Closing as we decided not to rename the file

@mkhamoyan mkhamoyan closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants