Fix ImageBuild Auth, message stream #451
Conversation
|
Hi all, We've been using this change in production for about 2 months now without issue. Would love some eyes on it now that the package-signing has been figured out, so that we can migrate off of our custom packaged binary! |
|
Can this pr get some attention please? We could really do with the changes being rolled out |
|
Sorry folks. As this PR was created before the recent updates and move with the CI to GitHub Actions I can re-run the CI here. @jhenkens do you mind rebasing the code on master and push the changes to the PR? Maybe that will trigger the CI. If it doesn't, we can close this PR and open a new one. Thanks! |
|
Test failed, but it looks like this is the only run of Test? Do we know if it passes on master? https://github.com/dotnet/Docker.DotNet/actions?query=workflow%3ACI |
|
It should pass, this is the first run on this CI, GitHub actions, the tests were fine running on AppVeyor before... |
|
Hi @galvesribeiro - I just force pushed an empty commit https://github.com/dotnet/Docker.DotNet/actions/runs/208786293 |
|
Hi all - is there something I should do at this point? CI did not pass on a commit that had a zero-file diff from master, and is thus broken on master. |
|
@galvesribeiro Is there any possibility to get this looked at again? Or shall I consider this PR dead? |
|
Hello @jhenkens I'll try get the CI working here. The tests were working on my machine when I had the project migrated here. I've been working on the vNext of this package recently and we should have something by the time we have .Net 5 out. Will update it soon. |
|
Any update on this? |
|
Would also find this useful, any update? |
|
Please |
|
please merge this PR |
Fixes #445 and #417
Properly parses the response from ImageBuild as a progress stream, and properly initializes and passes the AuthConfigs via header. Confirmed working with local usage.
Please guide me towards any other changes if needed to get this merged in, or feel free to contribute to clean the MR up.