Add Directory.Build.props. #2120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xljiulang
commented
Dec 4, 2024
Directory.Build.props
Outdated
| <NuGetAuditMode>all</NuGetAuditMode> | ||
| <NuGetAudit>true</NuGetAudit> | ||
| <NuGetAuditLevel>low</NuGetAuditLevel> | ||
| <AnalysisLevel>latest-Recommended</AnalysisLevel> |
There was a problem hiding this comment.
In my IDE, the latest-Recommended value causes hundreds of syntax errors.
There was a problem hiding this comment.
xljiulang
commented
Dec 4, 2024
| <RepositoryUrl>https://github.com/dotnet/MQTTnet.git</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
|
|
||
| <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> |
There was a problem hiding this comment.
After enabling ContinuousIntegrationBuild, it affects the lower breakpoint of the upper-level project in Debug configuration. Can we add a condition here to enable it only in Release configuration?
There was a problem hiding this comment.
Enabling ContinuousIntegrationBuild for RELEASE builds only sounds reasonable to be me because DEBUG builds are usually not built using the CI. They are only built on local machines.
… ContinuousIntegrationBuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a Directory.Build.props file to the solution and moved the common PropertyGroups and ItemGroups in each project into this file.