Skip to content

Disable flaky DiagnosticTest tests#3712

Merged
paulmedynski merged 1 commit into
mainfrom
dev/paul/diag-tests-skip
Oct 22, 2025
Merged

Disable flaky DiagnosticTest tests#3712
paulmedynski merged 1 commit into
mainfrom
dev/paul/diag-tests-skip

Conversation

@paulmedynski
Copy link
Copy Markdown
Contributor

Description

Temporarily disabled flaky DiagnosticTest tests. We will improve and re-enable them in the future.

@paulmedynski paulmedynski requested a review from a team as a code owner October 22, 2025 15:30
Copilot AI review requested due to automatic review settings October 22, 2025 15:30
@paulmedynski paulmedynski added the Area\Tests Issues that are targeted to tests or test projects label Oct 22, 2025
@paulmedynski paulmedynski changed the title Disabled flaky DiagnosticTest tests. Disable flaky DiagnosticTest tests Oct 22, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily disables a flaky test class (DiagnosticTest) by wrapping it in #if false preprocessor directives until the underlying issues can be investigated and resolved.

Key Changes

  • Added preprocessor directives to disable the entire DiagnosticTest class
  • Added a TODO comment referencing ticket ADO-39873 for tracking the re-enablement

@paulmedynski paulmedynski added this to the 7.0.0-preview3 milestone Oct 22, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.62%. Comparing base (37a9c99) to head (9af424d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3712      +/-   ##
==========================================
- Coverage   77.35%   76.62%   -0.74%     
==========================================
  Files         271      266       -5     
  Lines       45123    45021     -102     
==========================================
- Hits        34907    34499     -408     
- Misses      10216    10522     +306     
Flag Coverage Δ
addons ?
netcore 76.58% <ø> (-0.76%) ⬇️
netfx 76.20% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit ec18bab into main Oct 22, 2025
252 checks passed
@paulmedynski paulmedynski deleted the dev/paul/diag-tests-skip branch October 22, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Tests Issues that are targeted to tests or test projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants