Skip to content

Tests | ActiveIssues (Part 4) #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benrr101 merged 16 commits into from
Nov 20, 2025
Merged

Tests | ActiveIssues (Part 4) #3750

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d543a1b
Reenable tests in SqlCommandCancelTest: TimeoutCancelTcp, TimeoutCanc…
benrr101 Oct 6, 2025
cafa83b
Reenable tests in SqlCredentialTest - SqlConnectionChangePasswordPlai…
benrr101 Oct 6, 2025
b5dd2fe
Very light cleanup of SqlCredentialTest
benrr101 Oct 6, 2025
0815d29
Reenable MarsSessionPoolingTest in MarsExecuteReader_Text_WithGC and …
benrr101 Oct 6, 2025
317f456
Split tests into separate tests for each scenario, discover which tes…
benrr101 Oct 7, 2025
20f46f7
Mostly working . Except for those no close tests
benrr101 Oct 8, 2025
c1f9ac1
Clean up old code, but the nocloses test still breaks everything - ne…
benrr101 Oct 9, 2025
814736f
Clean up a biiiit more
benrr101 Oct 10, 2025
d2a7930
Finishing test matrix, improving DisposableArray, renaming test file …
benrr101 Nov 5, 2025
099bc0b
Final iteration of tests, adding backoff to DMV queries, adding #null…
benrr101 Nov 6, 2025
976c6fe
Fix mistakes in MARS tests
benrr101 Nov 6, 2025
f17d382
Rewrite TimeoutCancel to use less custom utilities - hopefully this w…
benrr101 Nov 7, 2025
9dec519
Fix session => request comment
benrr101 Nov 7, 2025
55887af
Re-disable TimeoutCancelNamedPipe due to bug in managed SNI implement…
benrr101 Nov 10, 2025
27e9f3d
Remove AreConnStringsNotAzureSynapse
benrr101 Nov 11, 2025
a41e768
Merge branch 'main' into dev/russellben/active-issues4
benrr101 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,9 @@ public static bool AreConnStringsSetup()
return !string.IsNullOrEmpty(NPConnectionString) && !string.IsNullOrEmpty(TCPConnectionString);
}

public static bool AreConnStringsNotAzureSynapse() =>
Comment thread
mdaigle marked this conversation as resolved.
Outdated
AreConnStringsSetup() && IsNotAzureSynapse();

public static bool IsSQL2022() => string.Equals("16", SQLServerVersion.Trim());

public static bool IsSQL2019() => string.Equals("15", SQLServerVersion.Trim());
Expand Down
204 changes: 158 additions & 46 deletions ...oft.Data.SqlClient/tests/ManualTests/SQL/MARSSessionPoolingTest/MARSSessionPoolingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Microsoft.Data.SqlClient.ManualTesting.Tests
{
public static class MARSSessionPoolingTest
public class MARSSessionPoolingTest
{
private const string COMMAND_STATUS = "select count(*) as ConnectionCount, @@spid as spid from sys.dm_exec_connections where session_id=@@spid and net_transport='Session'; " +
"select count(*) as ActiveRequestCount, @@spid as spid from sys.dm_exec_requests where session_id=@@spid and status='running' or session_id=@@spid and status='suspended'";
Expand All @@ -33,57 +33,169 @@ public static class MARSSessionPoolingTest
}).ConnectionString;

// Synapse: Catalog view 'dm_exec_connections' is not supported in this version.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public static void MarsExecuteScalar_AllFlavors()
{
TestMARSSessionPooling("Case: Text, ExecuteScalar", _testConnString, CommandType.Text, ExecuteType.ExecuteScalar, ReaderTestType.ReaderClose, GCType.Wait);
TestMARSSessionPooling("Case: RPC, ExecuteScalar", _testConnString, CommandType.StoredProcedure, ExecuteType.ExecuteScalar, ReaderTestType.ReaderClose, GCType.Wait);
}

// Synapse: Catalog view 'dm_exec_connections' is not supported in this version.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public static void MarsExecuteNonQuery_AllFlavors()
{
TestMARSSessionPooling("Case: Text, ExecuteNonQuery", _testConnString, CommandType.Text, ExecuteType.ExecuteNonQuery, ReaderTestType.ReaderClose, GCType.Wait);
TestMARSSessionPooling("Case: RPC, ExecuteNonQuery", _testConnString, CommandType.StoredProcedure, ExecuteType.ExecuteNonQuery, ReaderTestType.ReaderClose, GCType.Wait);
}
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteScalar_Text() =>
TestMARSSessionPooling(
"Case: Text, ExecuteScalar",
_testConnString,
CommandType.Text,
ExecuteType.ExecuteScalar,
ReaderTestType.ReaderClose,
GCType.Wait);

// Synapse: Catalog view 'dm_exec_connections' is not supported in this version.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public static void MarsExecuteReader_Text_NoGC()
{
TestMARSSessionPooling("Case: Text, ExecuteReader, ReaderClose", _testConnString, CommandType.Text, ExecuteType.ExecuteReader, ReaderTestType.ReaderClose, GCType.Wait);
TestMARSSessionPooling("Case: Text, ExecuteReader, ReaderDispose", _testConnString, CommandType.Text, ExecuteType.ExecuteReader, ReaderTestType.ReaderDispose, GCType.Wait);
TestMARSSessionPooling("Case: Text, ExecuteReader, ConnectionClose", _testConnString, CommandType.Text, ExecuteType.ExecuteReader, ReaderTestType.ConnectionClose, GCType.Wait);
}
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteScalar_Sproc() =>
Comment thread
paulmedynski marked this conversation as resolved.
Outdated
TestMARSSessionPooling(
"Case: RPC, ExecuteScalar",
_testConnString,
CommandType.StoredProcedure,
ExecuteType.ExecuteScalar,
ReaderTestType.ReaderClose,
GCType.Wait);

// Synapse: Stored procedure sp_who does not exist or is not supported.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public static void MarsExecuteReader_RPC_NoGC()
{
TestMARSSessionPooling("Case: RPC, ExecuteReader, ReaderClose", _testConnString, CommandType.StoredProcedure, ExecuteType.ExecuteReader, ReaderTestType.ReaderClose, GCType.Wait);
TestMARSSessionPooling("Case: RPC, ExecuteReader, ReaderDispose", _testConnString, CommandType.StoredProcedure, ExecuteType.ExecuteReader, ReaderTestType.ReaderDispose, GCType.Wait);
TestMARSSessionPooling("Case: RPC, ExecuteReader, ConnectionClose", _testConnString, CommandType.StoredProcedure, ExecuteType.ExecuteReader, ReaderTestType.ConnectionClose, GCType.Wait);
}
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteNonQuery_Text() =>
TestMARSSessionPooling(
"Case: Text, ExecuteNonQuery",
_testConnString,
CommandType.Text,
ExecuteType.ExecuteNonQuery,
ReaderTestType.ReaderClose,
GCType.Wait);

// Synapse: Catalog view 'dm_exec_connections' is not supported in this version.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public static void MarsExecuteReader_Text_WithGC()
{
TestMARSSessionPooling("Case: Text, ExecuteReader, GC-Wait", _testConnString, CommandType.Text, ExecuteType.ExecuteReader, ReaderTestType.ReaderGC, GCType.Wait);
TestMARSSessionPooling("Case: Text, ExecuteReader, GC-NoWait", _testConnString, CommandType.Text, ExecuteType.ExecuteReader, ReaderTestType.ReaderGC, GCType.NoWait);
}
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteNonQuery_Sproc() =>
TestMARSSessionPooling(
"Case: RPC, ExecuteNonQuery",
_testConnString,
CommandType.StoredProcedure,
ExecuteType.ExecuteNonQuery,
ReaderTestType.ReaderClose,
GCType.Wait);

// Synapse: Stored procedure sp_who does not exist or is not supported.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public static void MarsExecuteReader_StoredProcedure_WithGC()
{
TestMARSSessionPooling("Case: RPC, ExecuteReader, GC-Wait", _testConnString, CommandType.StoredProcedure, ExecuteType.ExecuteReader, ReaderTestType.ReaderGC, GCType.Wait);
TestMARSSessionPooling("Case: RPC, ExecuteReader, GC-NoWait", _testConnString, CommandType.StoredProcedure, ExecuteType.ExecuteReader, ReaderTestType.ReaderGC, GCType.NoWait);
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_TextNoGc_ReaderClose() =>
TestMARSSessionPooling(
"Case: Text, ExecuteReader, ReaderClose",
_testConnString,
CommandType.Text,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderClose,
GCType.Wait);

TestMARSSessionPooling("Case: Text, ExecuteReader, NoCloses", _testConnString + " ", CommandType.Text, ExecuteType.ExecuteReader, ReaderTestType.NoCloses, GCType.Wait);
TestMARSSessionPooling("Case: RPC, ExecuteReader, NoCloses", _testConnString + " ", CommandType.StoredProcedure, ExecuteType.ExecuteReader, ReaderTestType.NoCloses, GCType.Wait);
}
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_TextNoGc_ReaderDispose() =>
TestMARSSessionPooling(
"Case: Text, ExecuteReader, ReaderDispose",
_testConnString,
CommandType.Text,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderDispose,
GCType.Wait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_TextNoGc_ConnectionClose() =>
TestMARSSessionPooling(
"Case: Text, ExecuteReader, ConnectionClose",
_testConnString,
CommandType.Text,
ExecuteType.ExecuteReader,
ReaderTestType.ConnectionClose,
GCType.Wait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_SprocNoGc_ReaderClose() =>
TestMARSSessionPooling(
"Case: RPC, ExecuteReader, ReaderClose",
_testConnString,
CommandType.StoredProcedure,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderClose,
GCType.Wait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_SprocNoGc_ReaderDispose() =>
TestMARSSessionPooling(
"Case: RPC, ExecuteReader, ReaderDispose",
_testConnString,
CommandType.StoredProcedure,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderDispose,
GCType.Wait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_SprocNoGc_ConnectionClose() =>
TestMARSSessionPooling(
"Case: RPC, ExecuteReader, ConnectionClose",
_testConnString,
CommandType.StoredProcedure,
ExecuteType.ExecuteReader,
ReaderTestType.ConnectionClose,
GCType.Wait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_TextWithGc_GcWait() =>
TestMARSSessionPooling(
"Case: Text, ExecuteReader, GC-Wait",
_testConnString,
CommandType.Text,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderGC,
GCType.Wait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_TextWithGc_GcNoWait() =>
TestMARSSessionPooling(
"Case: Text, ExecuteReader, GC-NoWait",
_testConnString,
CommandType.Text,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderGC,
GCType.NoWait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_SprocWithGc_GcWait() =>
TestMARSSessionPooling(
"Case: RPC, ExecuteReader, GC-Wait",
_testConnString,
CommandType.StoredProcedure,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderGC,
GCType.Wait);

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_SprocWithGc_GcNoWait() =>
TestMARSSessionPooling(
"Case: RPC, ExecuteReader, GC-Wait",
_testConnString,
CommandType.StoredProcedure,
ExecuteType.ExecuteReader,
ReaderTestType.ReaderGC,
GCType.Wait);

// Disabling as this there is a race condition somewhere in it
[ActiveIssue("Flaky, race condition")]
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_TextWithGc_NoCloses() =>
TestMARSSessionPooling(
"Case: Text, ExecuteReader, NoCloses",
_testConnString + " ",
CommandType.Text,
ExecuteType.ExecuteReader,
ReaderTestType.NoCloses,
GCType.Wait);

[ActiveIssue("Flaky, race condition")]
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.IsNotManagedInstance))]
public void MarsExecuteReader_SprocWithGc_NoCloses() =>
TestMARSSessionPooling(
"Case: RPC, ExecuteReader, NoCloses",
_testConnString + " ",
CommandType.StoredProcedure,
ExecuteType.ExecuteReader,
ReaderTestType.NoCloses,
GCType.Wait);

private enum ExecuteType
{
Expand Down