[6.1] Disable incompatible tests for managed instance #3881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request disables tests that are incompatible with SQL Managed Instance by adding the IsNotManagedInstance condition to test attributes. The changes align with the requirements mentioned in issue #3678.
Changes:
- Vector tests (VectorTypeBackwardCompatibilityTests and NativeVectorFloat32Tests) exclude Managed Instance as it doesn't support the Vector type
- JSON tests (JsonStreamTest and JsonBulkCopyTest) exclude Managed Instance as it doesn't support the JSON type
- MARS tests (MARSSessionPoolingTest) exclude Managed Instance as MARS is not supported
- DistributedTransactionTest excludes Managed Instance with documented error behavior
- ConnectionResiliencySPIDTest excludes Managed Instance
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| VectorTypeBackwardCompatibilityTests.cs | Added IsNotManagedInstance condition to 9 vector backward compatibility tests |
| NativeVectorFloat32Tests.cs | Added IsNotManagedInstance condition to 7 native vector tests |
| DistributedTransactionTest.Windows.cs | Added IsNotManagedInstance() call to test condition with explanatory comment |
| MARSSessionPoolingTest.cs | Added IsNotManagedInstance condition to 6 MARS-related tests |
| JsonStreamTest.cs | Added IsNotManagedInstance and AreConnStringsSetup conditions to 2 JSON streaming tests |
| JsonBulkCopyTest.cs | Added IsNotManagedInstance and AreConnStringsSetup conditions to 2 JSON bulk copy tests |
| ConnectivityTest.cs | Added IsNotManagedInstance condition to ConnectionResiliencySPIDTest |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs
Outdated
Show resolved
Hide resolved
...t.Data.SqlClient/tests/ManualTests/SQL/TransactionTest/DistributedTransactionTest.Windows.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs
Outdated
Show resolved
Hide resolved
paulmedynski
previously approved these changes
Jan 12, 2026
paulmedynski
approved these changes
Jan 12, 2026
mdaigle
approved these changes
Jan 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3881 +/- ##
===============================================
+ Coverage 65.42% 67.50% +2.08%
===============================================
Files 279 279
Lines 53302 53302
===============================================
+ Hits 34875 35984 +1109
+ Misses 18427 17318 -1109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable incompatible tests for managed instance.
This is same as mentioned in #3678
Issues
AB#41617
Testing
Tests will be enabled again once the required permissions are granted on the test user through #3880.
Guidelines
Please review the contribution guidelines before submitting a pull request: