Skip to content

Conversation

@apoorvdeshmukh
Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh commented Jan 12, 2026

Description

Following tests require additional user permissions

  • ConnectionResiliencySPIDTest
  • MARS tests

Issues

AB#41375

Testing

Tests will be enabled again once the require permissions are granted on the test user through #3880.

Guidelines

Please review the contribution guidelines before submitting a pull request:

Copilot AI review requested due to automatic review settings January 12, 2026 17:21
@apoorvdeshmukh apoorvdeshmukh requested a review from a team as a code owner January 12, 2026 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables tests that require additional user permissions when running against Azure SQL Managed Instance. The tests query system views (sys.dm_exec_connections) and execute admin commands (KILL) that the current test user doesn't have permissions for on Managed Instance. The tests will be re-enabled once the necessary permissions are granted per issue #3880.

Changes:

  • Added IsNotManagedInstance() helper method to DataTestUtility class
  • Updated 6 MARS test methods to skip execution on Managed Instance
  • Updated ConnectionResiliencySPIDTest to skip execution on Managed Instance

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Added IsNotManagedInstance() helper method following the existing pattern used for IsNotAzureSynapse()
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSSessionPoolingTest/MARSSessionPoolingTest.cs Added IsNotManagedInstance condition to 6 MARS test methods that query sys.dm_exec_connections
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/ConnectivityTest.cs Added IsNotManagedInstance condition to ConnectionResiliencySPIDTest which uses the KILL command

@paulmedynski paulmedynski self-assigned this Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.50%. Comparing base (cda77d0) to head (46f6f2c).
⚠️ Report is 3 commits behind head on release/6.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/6.0    #3882      +/-   ##
===============================================
- Coverage        66.72%   63.50%   -3.23%     
===============================================
  Files              285      285              
  Lines            59160    59160              
===============================================
- Hits             39472    37567    -1905     
- Misses           19688    21593    +1905     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 67.97% <ø> (-4.45%) ⬇️
netfx 64.97% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apoorvdeshmukh apoorvdeshmukh merged commit 7ec045f into release/6.0 Jan 12, 2026
246 checks passed
@apoorvdeshmukh apoorvdeshmukh deleted the dev/ad/disable-incompat-tests-for60 branch January 12, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants