Port #3828 to release/6.0#3889
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ports changes from PR #3828 to the release/6.0 branch to fix CodeCoverage upload issues in Azure DevOps pipelines. The changes introduce a mechanism to conditionally control whether code coverage results are uploaded to CodeCov based on a pipeline variable.
Changes:
- Removes the default value for the
uploadparameter in the code coverage job template - Adds explicit configuration of the
uploadparameter using a pipeline variableci_var_uploadTestResultwith comprehensive documentation comments
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Adds the upload parameter configuration using a pipeline variable with detailed comments explaining how to set it up in Azure DevOps UI |
| eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml | Removes the default value for the upload parameter, requiring callers to explicitly specify whether to upload to CodeCov |
|
See the changes I made to code coverage upload in #3856. The pipeline variable is not available at compile time and so it not compatible with the ${{}} reference style. It's possible to do it with a dynamically evaluated reference, but I think the parameter approach (what's included in my PR) is simple and allows us to adjust the value when manually invoking a pipeline. |
github-project-automation
Bot
moved this from To triage
to In progress
in SqlClient Board
samsharma2700
dismissed stale reviews from apoorvdeshmukh, paulmedynski, and mdaigle
via
9614f17
|
Based on internal discussion abandoning this PR in favor of #3894 |
Description
Port 3828 to release/6.1 to fix CodeCoverage upload issues observed in ADO.
Issues
41643