Skip to content

Test | Fix Transient Fault handling and other flaky unit tests #4080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdaigle merged 5 commits into from
Mar 25, 2026

Fix one more cases of possible error scenarios

e7dd518
Select commit
Loading
Failed to load commit list.
Merged

Test | Fix Transient Fault handling and other flaky unit tests #4080

Fix one more cases of possible error scenarios
e7dd518
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Package succeeded Mar 24, 2026 in 1h 37m 17s

Build #08313 had test failures

66 errors / 6 warnings

Details

Tests

  • Failed: 14 (0.01%)
  • Passed: 174,722 (96.49%)
  • Other: 6,341 (3.50%)
  • Total: 181,077

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 490 in build2.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

build2.proj#L490 

build2.proj(490,5): Error MSB3073: The command " "dotnet" test "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --filter "category=flaky" -f net8.0 -p:TestSet="3" --results-directory "TestResults" --logger:"trx;LogFilePrefix=MdsManual-Windows_NT-net8.0-3" -p:ReferenceType=Package -p:AbstractionsPackageVersion=1.0.0.08313-ci -p:LoggingPackageVersion=1.0.0.08313-ci -p:MdsPackageVersion=7.0.0.08313-ci " exited with code 1.

Check failure on line 87 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L87 

Process 'msbuild.exe' exited with code '1'.

Check failure on line 59 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L59 

Error: The process '/opt/hostedtoolcache/dotnet/dotnet' failed with exit code 1

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.ConnectionOpenAsyncTest

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.ConnectionOpenAsyncTest 

Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
Raw output 
Child exception:
  System.AggregateException: One or more errors occurred. (Missing diagnostic 'Microsoft.Data.SqlClient.WriteConnectionOpenAfter')
 ---> Xunit.Sdk.TrueException: Missing diagnostic 'Microsoft.Data.SqlClient.WriteConnectionOpenAfter'
   at Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.CollectStatisticsDiagnosticsAsync(Func`2 sqlOperation, String[] expectedDiagnostics, String methodName) in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/DiagnosticTest.cs:line 960
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.<>c.<ConnectionOpenAsyncTest>b__29_0() in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/DiagnosticTest.cs:line 513
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Child process:
  ManualTests, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest+<>c Int32 <ConnectionOpenAsyncTest>b__29_0()

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.ConnectionOpenAsyncErrorTest

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.ConnectionOpenAsyncErrorTest 

Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
Raw output 
Child exception:
  System.AggregateException: One or more errors occurred. ---> Xunit.Sdk.TrueException: Missing diagnostic 'Microsoft.Data.SqlClient.WriteConnectionOpenError'
   at Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.<CollectStatisticsDiagnosticsAsync>d__32.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.<>c.<ConnectionOpenAsyncErrorTest>b__30_0()
---> (Inner Exception #0) Xunit.Sdk.TrueException: Missing diagnostic 'Microsoft.Data.SqlClient.WriteConnectionOpenError'
   at Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest.<CollectStatisticsDiagnosticsAsync>d__32.MoveNext()<---


Child process:
  ManualTests, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null Microsoft.Data.SqlClient.ManualTesting.Tests.DiagnosticTest+<>c Int32 <ConnectionOpenAsyncErrorTest>b__30_0()

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.XEventsTracingTest.XEventActivityIDConsistentWithTracing(query: "sp_help", commandType: StoredProcedure, xEvent: "rpc_starting")

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.XEventsTracingTest.XEventActivityIDConsistentWithTracing(query: "sp_help", commandType: StoredProcedure, xEvent: "rpc_starting") 

Microsoft.Data.SqlClient.SqlException : Transaction (Process ID 198) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlDataReader.TryHasMoreRows(Boolean& moreRows)
   at Microsoft.Data.SqlClient.SqlDataReader.TryReadInternal(Boolean setTimeout, Boolean& more)
   at Microsoft.Data.SqlClient.SqlDataReader.Read()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.XEventsTracingTest.XEventActivityIDConsistentWithTracing(String query, CommandType commandType, String xEvent) in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/XEventsTracingTest.cs:line 132
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.XEventsTracingTest.XEventActivityIDConsistentWithTracing(query: "sp_help", commandType: StoredProcedure, xEvent: "rpc_starting")

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.XEventsTracingTest.XEventActivityIDConsistentWithTracing(query: "sp_help", commandType: StoredProcedure, xEvent: "rpc_starting") 

Microsoft.Data.SqlClient.SqlException : Transaction (Process ID 154) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlDataReader.TryHasMoreRows(Boolean& moreRows)
   at Microsoft.Data.SqlClient.SqlDataReader.TryReadInternal(Boolean setTimeout, Boolean& more)
   at Microsoft.Data.SqlClient.SqlDataReader.Read()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.XEventsTracingTest.XEventActivityIDConsistentWithTracing(String query, CommandType commandType, String xEvent) in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/XEventsTracingTest.cs:line 132
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
View more details on Azure Pipelines