Skip to content

Replace Newtonsoft.Json with System.Text.Json in tests and samples #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulmedynski wants to merge 2 commits into
base: dev/russellben/config-jsonc
Choose a base branch
from
+116 −450

Fix JSON test comparison to handle Unicode escape differences

312ca72
Select commit
Loading
Failed to load commit list.
Draft

Replace Newtonsoft.Json with System.Text.Json in tests and samples #4323

Fix JSON test comparison to handle Unicode escape differences
312ca72
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Package failed May 29, 2026 in 3h 30m 32s

Build #14914 had test failures

133 errors / 95 warnings

Details

Tests

  • Failed: 7 (0.00%)
  • Passed: 180,617 (96.71%)
  • Other: 6,131 (3.28%)
  • Total: 186,755

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 675 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

build.proj#L675 

build.proj(675,5): Error MSB3073: The command " "dotnet" test "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --collect "Code coverage" --settings "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/CodeCoverage.runsettings" --filter "category!=failing&category!=flaky&category!=interactive&category!=signed" -f net8.0 -p:TestSet="3" --results-directory "TestResults" --logger:"trx;LogFilePrefix=SqlClientManual-Windows_NT-net8.0-3" -p:ReferenceType=Package -p:AbstractionsPackageVersion=1.1.0-preview1ci14914 -p:LoggingPackageVersion=1.1.0-preview1ci14914 -p:SqlClientPackageVersion=7.1.0-preview1ci14914 -p:SqlServerPackageVersion=1.1.0-preview1ci14914 " exited with code 1.

Check failure on line 243 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L243 

Error: The process 'C:\hostedtoolcache\windows\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 246 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L246 

Dotnet command failed with non-zero exit code on the following projects : [ 'D:\\a\\_work\\1\\s\\build.proj' ]

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.TvpColumnBoundariesTests.TvpColumnBoundariesTest

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.TvpColumnBoundariesTests.TvpColumnBoundariesTest 

Assert.True() Failure
Expected: True
Actual:   False
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.TvpColumnBoundariesTests.TvpColumnBoundariesTest() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\TvpColumnBoundariesTests.cs:line 25
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly 

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding.
Operation cancelled by user.
---- System.ComponentModel.Win32Exception : The wait operation timed out.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 343
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 310
   at InvokeStub_SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
----- Inner Stack Trace -----

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly 

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding.
Operation cancelled by user.
---- System.ComponentModel.Win32Exception : The wait operation timed out.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 343
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 310
   at InvokeStub_SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
----- Inner Stack Trace -----

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly 

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding.
Operation cancelled by user.
---- System.ComponentModel.Win32Exception : The wait operation timed out.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 343
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 310
   at InvokeStub_SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
----- Inner Stack Trace -----
View more details on Azure Pipelines