Skip to content

Add TDS token data length bounds checks #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulmedynski wants to merge 8 commits into
base: main
Choose a base branch
from
+1,194 −9

Address second round of Copilot review feedback

9f4bcf0
Select commit
Loading
Failed to load commit list.
Draft

Add TDS token data length bounds checks #4340

Address second round of Copilot review feedback
9f4bcf0
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Project (MacOSLatest_Sql22 net9_0_AnyCPU_ManagedSNI_3) succeeded Jun 5, 2026 in 59m 2s

MacOSLatest_Sql22 net9_0_AnyCPU_ManagedSNI_3 succeeded with issues

12 errors / 3 warnings

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (MacOSLatest_Sql22 net9_0_AnyCPU_ManagedSNI_3)

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 689 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (MacOSLatest_Sql22 net9_0_AnyCPU_ManagedSNI_3)

build.proj#L689 

build.proj(689,5): Error MSB3073: The command " "dotnet" test "/Users/runner/work/1/s/src/../src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --collect "Code coverage" --settings "/Users/runner/work/1/s/src/../src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/CodeCoverage.runsettings" --filter "category!=failing&category!=flaky&category!=interactive&category!=signed" -f net9.0 -p:TestSet="3" --results-directory "TestResults" --logger:"trx;LogFilePrefix=SqlClientManual-Unix-net9.0-3" -p:AbstractionsPackageVersion=1.1.0-preview1ci15611 -p:LoggingPackageVersion=1.1.0-preview1ci15611 -p:SqlClientPackageVersion=7.1.0-preview1ci15611 -p:SqlServerPackageVersion=1.1.0-preview1ci15611 " exited with code 1.

Check failure on line 137 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (MacOSLatest_Sql22 net9_0_AnyCPU_ManagedSNI_3)

Build log #L137 

Error: The process '/Users/runner/hostedtoolcache/dotnet/dotnet' failed with exit code 1

Check failure on line 140 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (MacOSLatest_Sql22 net9_0_AnyCPU_ManagedSNI_3)

Build log #L140 

Dotnet command failed with non-zero exit code on the following projects : [ '/Users/runner/work/1/s/build.proj' ]

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (MacOSLatest_Sql22 net9_0_AnyCPU_ManagedSNI_3)

EXEC#L0 

EXEC(0,0): Error Message:
View more details on Azure Pipelines