Skip to content

Enable ManagedPeer native registration for LLVM typemap - #11735

Merged
jonathanpeppers merged 1 commit into
dotnet:mainfrom
simonrozsival:dev/simonrozsival/managedpeer-native-registration
Jun 25, 2026
Merged

Enable ManagedPeer native registration for LLVM typemap#11735
jonathanpeppers merged 1 commit into
dotnet:mainfrom
simonrozsival:dev/simonrozsival/managedpeer-native-registration

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Non-trimmable LLVM typemap builds require Java.Interop's ManagedPeer native registration path. This makes the runtime host configuration explicit for the LLVM typemap target so the feature remains enabled when trimming/runtimeconfig options are generated.

Ensure non-trimmable LLVM typemap builds explicitly keep Java.Interop's ManagedPeer native registration enabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 25, 2026 11:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the Java.Interop ManagedPeer native registration feature switch explicit for the LLVM IR typemap build flavor, ensuring the required registration path remains enabled when runtimeconfig options are generated/trimmed.

Changes:

  • Adds a RuntimeHostConfigurationOption to explicitly enable Java.Interop.RuntimeFeature.ManagedPeerNativeRegistration for the LLVM IR typemap targets.
  • Minor formatting consolidation of the existing TrimmableTypeMap=false runtime host configuration option.
Show a summary per file
File Description
src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.TypeMap.LlvmIr.targets Forces the ManagedPeer native registration runtime feature on for LLVM IR typemap builds via runtimeconfig/AppContext switch generation.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@jonathanpeppers
jonathanpeppers merged commit c2f553d into dotnet:main Jun 25, 2026
40 checks passed
@jonathanpeppers

Copy link
Copy Markdown
Member

/backport to release/11.0.1xx-preview6

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx-preview6 (link to workflow run)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants