-
Notifications
You must be signed in to change notification settings - Fork 552
[nativeaot] support for Application
subclasses
#9716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c31cd86
[nativeaot] support for `Application` subclasses
jonathanpeppers 8be4ee6
Address feedback
jonathanpeppers 9185a8a
Update MainActivity.cs
jonathanpeppers 1d6d4c3
CodeGenerationTarget allowed to be blank
jonathanpeppers 572399e
Update NativeAotTypeManager.cs
jonathanpeppers 4f04038
`net.dot.jni` -> `net.dot.android`
jonathanpeppers 68d632b
Update GenerateJavaStubs.cs
jonathanpeppers f3c122e
Update Object.GetObject() to use JniRuntime.JniValueManager
jonpryor 7376e72
Revert "Update Object.GetObject() to use JniRuntime.JniValueManager"
jonpryor ea8ac63
Merge remote-tracking branch 'origin/main' into dev/peppers/applicati…
jonpryor 84089ed
New NativeAotValueManager
jonathanpeppers d54546a
Use `Name` property instead of `[Register]`
jonathanpeppers 694e975
Fix Application subclass usage.
jonpryor 87088f4
Unused code
jonathanpeppers c19341f
Use HasFlag
jonathanpeppers 6b2ab27
JniRuntime.JniTypeManager to be less restrictive
jonathanpeppers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using Android.Runtime; | ||
using Android.Util; | ||
|
||
/// <summary> | ||
/// NOTE: This class is not required, but used for testing Android.App.Application subclasses. | ||
/// </summary> | ||
[Register ("my/MainApplication")] // Required for typemap in NativeAotTypeManager | ||
jonathanpeppers marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[Application] | ||
public class MainApplication : Application | ||
{ | ||
public MainApplication (IntPtr handle, JniHandleOwnership transfer) | ||
: base (handle, transfer) | ||
{ | ||
} | ||
|
||
public override void OnCreate () | ||
{ | ||
Log.Debug ("NativeAOT", "Application.OnCreate()"); | ||
|
||
base.OnCreate (); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/Xamarin.Android.Build.Tasks/Resources/ApplicationRegistration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.