Skip to content

Add UseArPowBuildInfra=false opt-out flag #15725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 10, 2025

Needed for dotnet/dotnet#176

This is a temporary flag that allows to build without the ArPow build infra in a DotNetBuild. This flag also makes the following conditions true: '$(DotNetBuildPhase)' == 'InnerRepo' and '$(DotNetBuildInnerRepo)' == 'true'

This can be removed when the outer/inner build infra is removed.


Also move the DotNetTargetFrameworkFilter logic into TargetFrameworkFilters.BeforeCommonTargets.targets so that it applies to non ArPow infra builds as well.

This is a temporary flag that allows to build without the ArPow build infra in a DotNetBuild.

This can be removed when the outer/inner build infra is removed.
@ViktorHofer ViktorHofer requested a review from mmitche April 10, 2025 20:32
@ViktorHofer ViktorHofer requested a review from a team as a code owner April 10, 2025 22:02
@ViktorHofer ViktorHofer merged commit 608a8a5 into main Apr 11, 2025
11 checks passed
@ViktorHofer ViktorHofer deleted the UseArPowBuildInfraOptOutFlag branch April 11, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants