Fix MTP runner to report error when given .dll for non-Core workloads #15885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MTP (Microsoft Testing Platform) runner in Arcade was incorrectly handling .dll files for non-Core (.NET Framework) workloads by executing them directly via shell execute. This could lead to unintended behavior, such as opening the .dll with associated programs (like ILSpy) instead of running tests.
Problem
When
TestRuntime
is not 'Core', the_TestRunner
property was set to$(_TestAssembly)
(line 31 in Microsoft.Testing.Platform.targets). If the assembly was a .dll file, it would be executed directly, causing the system to launch whatever program is associated with .dll files.Solution
Added validation to check that non-Core workloads use executable (.exe) files instead of .dll files:
Features
<OutputType>Exe</OutputType>
in the project file.exe
and.EXE
extensionsTesting
Verified the fix with multiple test scenarios:
Fixes #15884.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.