Keyless Build Promotion publishing (re-apply #17185) — gated on null-guard deploy#17189
Draft
missymessa wants to merge 2 commits into
Draft
Keyless Build Promotion publishing (re-apply #17185) — gated on null-guard deploy#17189missymessa wants to merge 2 commits into
missymessa wants to merge 2 commits into
Conversation
…keyless Entra publishing) (dotnet#17185)" This reverts commit b7d4e15.
…(keyless Entra publishing) (dotnet#17185)" This reverts commit 18d7b7b.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyless Build Promotion publishing (re-apply #17185)
Removes
AzureDevOpsFeedsKeyand theenable-cross-org-publishing.ps1 -tokenstep fromeng/publishing/v3/publish.yml. Publishing runs under themaestro-build-promotionfederated identity (Entra/WIF) instead of thedn-bot-all-orgs-artifact-feeds-rwPAT.This re-applies #17185, which was reverted by #17186 after it broke production Build Promotion.
The publishing task ships in the arcade SDK pinned by
global.json. Keyless publishing is only safe once the fixed task (null-guard from the companion PR) is the version Build Promotion actually runs. Required order:global.jsonbumped so Build Promotion consumes it.Merging this before the fixed task is live will reproduce the #17185 regression. Kept as draft until the gate above is satisfied.
Context