Refactor user secrets to DI-based factory with thread-safe synchronization #12695
+728
−281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports PR #12692 to this branch. Replaces static
SecretsStoremethods with a dependency injection-based factory pattern that provides thread-safe synchronization for user secrets file access.Architecture Changes
Factory & Interfaces:
IUserSecretsManager- interface for user secrets operationsUserSecretsManagerFactory- singleton factory with lock-based instance cachingNoopUserSecretsManager- null object pattern when user secrets not configuredJsonFlattener- utility for JSON flattening/unflattening (extracted fromDeploymentStateManagerBase)Thread Safety:
UserSecretsManagerinstance has its ownSemaphoreSlimCore Changes
DistributedApplicationBuilder- registersIUserSecretsManagersingleton in DI containerUserSecretsParameterDefault- factory-based constructor with optional custom factory for test isolationUserSecretsDeploymentStateManager- injectsIUserSecretsManagervia constructorVersionCheckService- injectsIUserSecretsManagerinstead of using static methodssrc/Shared/SecretsStore.csand static method callsTest Updates
JsonFlattenerTestsfrom Azure.Tests to Aspire.Hosting.TestsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.