Fix uncaught rangeerror by making manage logs/telemetry a page instead of dialog

[adamint]

Description

From the issue:

The root cause is opening a dialog (ManageDataDialog) within another dialog (SettingsDialog). Per fluentui-blazor, that is microsoft/fluentui-blazor#948. It's possible to work around this issue and still open the nested dialog, but nested dialogs are not a good design pattern, especially for accessibility. Instead, we should create a new 'manage logs and telemetry' page and redirect to it on click.

This PR creates a new page and removes the old dialog. The bottom buttons always appear on the bottom of the screen.

Fixes #14407

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire.dev issue:
      • New issue
  • No

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14560

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14560"

[Copilot]

Pull request overview

This PR resolves a FluentUI-Blazor nested-dialog focus recursion issue (manifesting as an uncaught RangeError) by replacing the “Manage logs and telemetry” dialog with a dedicated /managedata page and updating Settings to navigate to it.

Changes:

• Added a new ManageData page (Razor + code-behind + isolated CSS) at /managedata.
• Updated Settings dialog to navigate to the new page instead of opening a nested dialog.
• Added a DashboardUrls.ManageDataUrl() helper and removed the old ManageDataDialog.razor.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Shared/DashboardUrls.cs	Adds a /managedata URL helper for consistent navigation.
src/Aspire.Dashboard/Components/Pages/ManageData.razor	Introduces the new Manage Data page route and UI markup.
src/Aspire.Dashboard/Components/Pages/ManageData.razor.cs	Moves dialog logic to a page component and updates localization type usage.
src/Aspire.Dashboard/Components/Pages/ManageData.razor.css	Adjusts layout so grid scrolls while action buttons stay pinned at the bottom.
src/Aspire.Dashboard/Components/Dialogs/SettingsDialog.razor	Updates the Manage button click handler to navigate to the page.
src/Aspire.Dashboard/Components/Dialogs/SettingsDialog.razor.cs	Replaces nested dialog launch with navigation to /managedata.
src/Aspire.Dashboard/Components/Dialogs/ManageDataDialog.razor	Removes the obsolete dialog UI.

Comments suppressed due to low confidence (1)

src/Aspire.Dashboard/Components/Dialogs/SettingsDialog.razor:43

• There are existing Playwright tests covering the Settings dialog (e.g., theme changes). Since this change is specifically fixing a regression triggered by the Manage button (nested dialog focus recursion / RangeError), it would be good to add an automated regression test that clicks this button and verifies navigation to /managedata (and ideally asserts no console errors are emitted).

                <FluentButton IconStart="@(new Icons.Regular.Size16.Settings())"
                              OnClick="NavigateToManageData"
                              Title="@Loc[nameof(Dialogs.ManageDataManageButtonText)]"
                              aria-label="@Loc[nameof(Dialogs.ManageDataManageButtonText)]">
                    @Loc[nameof(Dialogs.ManageDataManageButtonText)]
                </FluentButton>

[Copilot]

A new URL helper was added here; the repo already has DashboardUrlsTests covering several URL builders. Consider adding a small unit test for ManageDataUrl() (and/or ManageDataBasePath) to keep coverage consistent and catch accidental route changes.

[Copilot]

NavigateToManageData is declared as async void but contains no await, which will produce CS1998 (and this repo treats warnings as errors). Also, since the settings dialog is tracked by MainLayout (_openPageDialog) and there’s no route-change handler to auto-close it, navigating here will leave the settings panel/dialog open over the destination page. Make this a Task-returning handler and close the current FluentDialog (via a CascadingParameter like other dialogs) before calling NavigationManager.NavigateTo(...).