-
Notifications
You must be signed in to change notification settings - Fork 609
[Automated] Update API Surface Area #8736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7d0c9c2
to
c0d5f4c
Compare
@@ -1982,16 +1995,28 @@ public void WriteConnectionString(ApplicationModel.IResource resource) { } | |||
public System.Threading.Tasks.Task WriteEnvironmentVariablesAsync(ApplicationModel.IResource resource) { throw null; } | |||
} | |||
|
|||
[System.Diagnostics.CodeAnalysis.Experimental("ASPIREPUBLISHERS001")] | |||
public sealed partial class NullPublishingActivityProgressReporter : IPublishingActivityProgressReporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in Aspire.Hosting or Aspire.Hosting.Testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I'm not 100% sure.
NullLogger is in Microsoft.Extensions.Logging.Abstractions. Although I don't think we have a logging testing package.
a280eea
to
f1e17ab
Compare
f1e17ab
to
9c201c5
Compare
cbed789
to
3752e74
Compare
6fe8795
to
a837a27
Compare
9f37c81
to
4c75793
Compare
4c75793
to
0a9815f
Compare
0a9815f
to
6e2feba
Compare
Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.