xunit1051 Part 1

[illay1994]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #8488

Fixed xunit1051 warning in following projects:

tests\Aspire.Azure.AI.OpenAI.Tests
tests\Aspire.Components.Common.Tests
tests\Aspire.Confluent.Kafka.Tests
tests\Aspire.Dashboard.Components.Tests
tests\Aspire.Elastic.Clients.Elasticsearch.Tests
tests\Aspire.Hosting.Analyzers.Tests
tests\Aspire.Hosting.Kubernetes.Tests
tests\Aspire.Hosting.Python.Tests
tests\Aspire.Hosting.Redis.Tests
tests\Aspire.Hosting.Seq.Tests
tests\Aspire.Hosting.SqlServer.Tests
tests\Aspire.Hosting.Testing.Tests
tests\Aspire.Hosting.Valkey.Tests
tests\Aspire.Milvus.Client.Tests
tests\Aspire.MongoDB.Driver.Tests
tests\Aspire.NATS.Net.Tests
tests\Aspire.OpenAI.Tests
tests\Aspire.Playground.Tests
tests\Aspire.Qdrant.Client.Tests
tests\Aspire.RabbitMQ.Client.Tests
tests\Aspire.StackExchange.Redis.Tests
tests\Aspire.Templates.Tests
tests\Microsoft.Extensions.ServiceDiscovery.Tests

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue (consider using one of the following templates):
      • New (or update) doc-idea template
      • New breaking-change template
      • New diagnostic template
  • No

[illay1994]

I don't want to make PR bigger.
After that i will create PR per project

[RussKie]

Please use GitHub keywords when referencing underlying issues. In this case, the body of the original message must contains "Fixes #8488" or alike. Ideally, the git commit must contain the same.

The same applies to all other pull-requests.

[illay1994]

Please use GitHub keywords when referencing underlying issues. In this case, the body of the original message must contains "Fixes #8488" or alike. Ideally, the git commit must contain the same.

The same applies to all other pull-requests.

Thanks.
I will follow this naming in future

[RussKie]

MC

[illay1994]

Hi @RussKie

Could you help me to find 4 failing test?

I spend 2 hours yesterday
I will fit it later today

[RussKie]

I believe here are the issues:

https://github.com/dotnet/aspire/actions/runs/14716303439/job/41300519858?pr=8951#step:19:4155

  failed Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_ResultsInExpectedResultForStatusCode(statusCode: 201, expectSuccess: True) (34s 926ms)
    Assert.Equal() Failure: Values differ
    Expected: True
    Actual:   False
      at Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_ResultsInExpectedResultForStatusCode(Int32 statusCode, Boolean expectSuccess) in /_/tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs:156
      --- End of stack trace from previous location ---

https://github.com/dotnet/aspire/actions/runs/14716303439/job/41300519858?pr=8951#step:19:3184

  failed Aspire.Hosting.Tests.SlimTestProgramTests.TestProjectStartsAndStopsCleanly (0ms)
    Xunit.Runner.InProc.SystemConsole.TestingPlatform.XunitException: Collection fixture type 'Aspire.Hosting.Tests.SlimTestProgramFixture' threw in InitializeAsync
    ---- System.Threading.Tasks.TaskCanceledException : A task was canceled.
      
      ----- Inner Stack Trace -----
      at Aspire.Hosting.Tests.SlimTestProgramFixture.WaitReadyStateAsync(CancellationToken cancellationToken) in /_/tests/Aspire.Hosting.Tests/TestProgramFixture.cs:68
      at Aspire.Hosting.Tests.TestProgramFixture.InitializeAsync() in /_/tests/Aspire.Hosting.Tests/TestProgramFixture.cs:37
  failed Aspire.Hosting.Tests.SlimTestProgramTests.TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatch (0ms)
    Xunit.Runner.InProc.SystemConsole.TestingPlatform.XunitException: Collection fixture type 'Aspire.Hosting.Tests.SlimTestProgramFixture' threw in InitializeAsync
    ---- System.Threading.Tasks.TaskCanceledException : A task was canceled.
      
      ----- Inner Stack Trace -----
      at Aspire.Hosting.Tests.SlimTestProgramFixture.WaitReadyStateAsync(CancellationToken cancellationToken) in /_/tests/Aspire.Hosting.Tests/TestProgramFixture.cs:68
      at Aspire.Hosting.Tests.TestProgramFixture.InitializeAsync() in /_/tests/Aspire.Hosting.Tests/TestProgramFixture.cs:37
  failed Aspire.Hosting.Tests.SlimTestProgramTests.TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatchForReplicatedServices (0ms)
    Xunit.Runner.InProc.SystemConsole.TestingPlatform.XunitException: Collection fixture type 'Aspire.Hosting.Tests.SlimTestProgramFixture' threw in InitializeAsync
    ---- System.Threading.Tasks.TaskCanceledException : A task was canceled.

These could be just flaky, but we can't know unless the conflict is resolved.

[danmoseley]

closing per comment in #9020.

@illay1994 thanks for the effort.