Fix tests #9077
Fix tests #9077
Conversation
github-actions
bot
added
the
area-engineering-systems
RussKie
force-pushed
the
igveliko/fix_testrunner
branch
from
0831eaf to
eba0481
Compare
RussKie
force-pushed
the
igveliko/fix_testrunner
branch
from
eba0481 to
42232dd
Compare
|
This is ready to merge |
| @@ -38,6 +38,9 @@ | |||
| <_CreateRunsheet Condition=" '$(_RequiresPackages)' != 'true' and '$(FullE2e)' != 'true' ">true</_CreateRunsheet> | |||
|
|
|||
| <_CreateRunsheet Condition=" '$(MSBuildProjectName)' == 'Aspire.Templates.Tests' ">false</_CreateRunsheet> | |||
|
|
|||
| <!-- FIXME: temporary workaround for https://github.com/Azure/azure-functions-dotnet-worker/issues/2969 --> | |||
| <_PreCommand Condition=" '$(MSBuildProjectName)' == 'Aspire.Playground.Tests' ">./dotnet.sh build "%24(pwd)/playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.Functions/AzureFunctionsEndToEnd.Functions.csproj" -c $(Configuration) /p:SkipUnstableEmulators=true && </_PreCommand> | |||
There was a problem hiding this comment.
Now that we have these command lines being generated per project, we should have this kind of project-specific stuff in the test projects themselves.
There was a problem hiding this comment.
This crossed my mind too, but I'm unsure how discoverable that may be.
There was a problem hiding this comment.
This is not going to be a common thing to do. And documentation can help with discoverability. But the customizations belong with the specific projects, IMHO.
|
Could you please do a new run because of the changes pushed after the last one? |
RussKie
force-pushed
the
igveliko/fix_testrunner
branch
from
42232dd to
f81aeb3
Compare
|
re:force-push, this makes it really hard to review changes on these PRs! Even looking at the
|
|
This is a clean rebase. |
Get the two failing tests running in GHA using the runsheet.