Simplify redis cache setup

[tebeco]

Add flexibility to AddStackExchangeRedisCache by removing setupAction

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Adds an overload to AddStackExchangeRedisCache without previously mandatory setupAction

Description

Add flexibility to AddStackExchangeRedisCache by removing setupAction

Fixes #49721

[ghost]

Thanks for your PR, @tebeco. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[mgravell]

Interestingly, the fact that there may be duplicated code between distributed cache and output cache came up separately, and may be a parallel motivation for this as a change. I need to check on API consistency, though.

[tebeco]

Am I supposed ... or not to change the PublicApi files ...
because I'm seeing contradictory failures such as:

But when I add it, it's telling me it shouldn't be updated and repeating the docs which says:

Is that supposed to be an error and a repo maintainer adds a commit to the PR ?

[tebeco]

Interestingly, the fact that there may be duplicated code between distributed cache and output cache came up separately, and may be a parallel motivation for this as a change. I need to check on API consistency, though.

Fine for me, hopping that it can land in net8.0 since i'm probably short in time with the release / RC ;)

[BrennanConroy]

https://github.com/dotnet/aspnetcore/blob/main/docs/APIBaselines.md#new-apis

A new entry needs to be added to the PublicAPI.Unshipped.txt file for a new API. For example:

[tebeco]

https://github.com/dotnet/aspnetcore/blob/main/docs/APIBaselines.md#new-apis

A new entry needs to be added to the PublicAPI.Unshipped.txt file for a new API. For example:

Ah ! thanks
I think I got it now, I though Shipped and Unshipped had other meaning.
So basically the Unshipped file is sort of the "next to be Shipped" Apis that will be added to the already Shipped from previous release ?

Hope I didn't mess the files/TFM since OutputCache is declared with #if NET7_0_OR_GREATER:

• AddStackExchangeRedisCache in all TFM
• AddStackExchangeRedisOutputCache only in the net8.0

[mgravell]

To set expectations: we'll have a look at this and discuss things internally but: we're rapidly approaching lockdown for net8, especially since this involves API changes.

[adityamandaleeka]

@mgravell I've assigned the issue (#49721) to you to drive figuring out the design.

[mgravell]

@tebeco as I'm sure you know, we didn't manage to get to this in net8, sorry - not least because of some last minute changes to the assembly layout. Now that we're coming up from air a bit, we can try to catch up with this; overall, it looks reasonable, but we'll need to reflect those changes, specifically: reflect the move of the bits to here. I've had a look at this locally, and it looks like it would be quicker to redo from "main" than to fix those conflicts, but I don't want to jump in an remove credit on the PR. Are you eager enough to update to reflect that? Alternatively, I can take it over - copying over the proposed changes. Thoughts?

[tebeco]

@tebeco as I'm sure you know, we didn't manage to get to this in net8, sorry - not least because of some last minute changes to the assembly layout. Now that we're coming up from air a bit, we can try to catch up with this; overall, it looks reasonable, but we'll need to reflect those changes, specifically: reflect the move of the bits to here. I've had a look at this locally, and it looks like it would be quicker to redo from "main" than to fix those conflicts, but I don't want to jump in an remove credit on the PR. Are you eager enough to update to reflect that? Alternatively, I can take it over - copying over the proposed changes. Thoughts?

I just realized i did not read through all your message, I just rebased the branch on top of the change I've seen.
If you think you need additional change, you're absolutly free to add more commit onto that branch / PR and go on

this should be enabled as well

[tebeco]

nop this is still active from the owner/op point of view

[tebeco]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 49722 in repo dotnet/aspnetcore

[adityamandaleeka]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[adityamandaleeka]

@mgravell Just making sure this is this still on your radar

[tebeco]

🫥

[tebeco]

🦤

[Copilot]

Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (4)

• src/Caching/StackExchangeRedis/src/PublicAPI/net462/PublicAPI.Unshipped.txt: Language not supported
• src/Caching/StackExchangeRedis/src/PublicAPI/net9.0/PublicAPI.Unshipped.txt: Language not supported
• src/Caching/StackExchangeRedis/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt: Language not supported
• src/Middleware/Microsoft.AspNetCore.OutputCaching.StackExchangeRedis/src/PublicAPI.Unshipped.txt: Language not supported

Comments suppressed due to low confidence (1)

src/Caching/StackExchangeRedis/src/StackExchangeRedisCacheServiceCollectionExtensions.cs:21

• The tag should be updated to match the existing documentation style. It should be 'The so that additional calls can be chained.'.

<returns>The <see cref="IServiceCollection"/> so that additional calls can be chained.</returns>

[mgravell]

echoing comment here: #49721 (comment)