Run static code analysis on IIS #58167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
feature-iis
BrennanConroy
commented
Oct 1, 2024
| @@ -268,56 +268,55 @@ Hash( | |||
| const GUID* pguid, | |||
| DWORD dwHash = 0) | |||
| { | |||
|
|
|||
| return * reinterpret_cast<const DWORD *>(const_cast<GUID*>(pguid)) + dwHash; | |||
| return pguid->Data1 + dwHash; | |||
There was a problem hiding this comment.
Want to call this one out since it's hidden amongst all the other changes.
typedef struct _GUID {
unsigned long Data1;
unsigned short Data2;
unsigned short Data3;
unsigned char Data4[ 8 ];
} GUID;
| @@ -576,7 +576,7 @@ REQUEST_NOTIFICATION_STATUS | |||
| strDescription.QueryStr(), | |||
| strDescription.QuerySizeCCH()); | |||
| } | |||
| (VOID)strDescription.SyncWithBuffer(); | |||
| std::ignore = strDescription.SyncWithBuffer(); | |||
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/ModuleEnvironment.cpp
Outdated
Show resolved
Hide resolved
BrennanConroy
requested review from
halter73,
JamesNK,
mgravell,
wtgodbe and
a team
as code owners
amcasey
reviewed
Oct 2, 2024
...nstallers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/lib/IISSetup.CommonLib.vcxproj
Outdated
Show resolved
Hide resolved
amcasey
approved these changes
Oct 3, 2024
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix our C++ projects to actually run static analysis.
Turns out we have >2000 errors but I didn't realize that before I started randomly updating bits of the code in reaction to some of the errors. So there is a random assortment of fixes before I ended up disabling a bunch of the rules.
We will work on enabling more rules in future PRs.