Handling CultureInfo.InvariantCulture in RequestLocalizationMiddleware #58844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-middleware
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks @cloudlucky. I posted a comment in the issue (#58843). Let's use the issue to discuss what should be done about this. |
|
@dotnet-policy-service agree |
|
This was referenced Nov 14, 2024
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Middleware/Localization/test/UnitTests/RequestLocalizationMiddlewareTest.cs:28
- The test case with an empty string as the parent culture might be incorrect. Please verify if this is intended or if it should be a specific culture.
[InlineData("zh-Hans-CN", "")]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling CultureInfo.InvariantCulture in RequestLocalizationMiddleware
Handle CultureInfo.InvariantCulture if it's supported by the option
Description
If we add CultureInfo.InvariantCulture as a supported culture the code rejecting it and defaulted to the default configured culture.
It's happening since version 8.
Fixes #58843
Test project: https://github.com/cloudlucky/RequestLocalizationMiddlewareCultureInvariant