Fixed the issue #60096
Merged
Fixed the issue #60096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-mvc
mkArtakMSFT
commented
Jan 29, 2025
src/Mvc/Mvc.Core/src/ApplicationModels/DefaultApplicationModelProvider.cs
Outdated
Show resolved
Hide resolved
mkArtakMSFT
force-pushed
the
mkArtakMSFT/issue_44988
branch
from
7886a25 to
c274bff
Compare
|
Yes - I just merged that, so re-kicking this should fix CI |
mkArtakMSFT
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
mkArtakMSFT
force-pushed
the
mkArtakMSFT/issue_44988
branch
from
9f01e34 to
6873581
Compare
|
@eerhardt somehow, I am unable to properly suppress these warnings, even though the suppressions have been generated. When running the suppression generation command locally, it doesn't make any other changes, which indicates that the suppressions are properly made in the file. So I'm not sure what else may be going on here. Can you take a look and see what I may be missing here? |
mkArtakMSFT
requested review from
eerhardt
and removed request for
mgravell,
halter73,
JamesNK and
BrennanConroy
|
So the manual "fix" that I did was done incorrectly and that was the culprit. Thank you, @eerhardt. @captainsafia this is ready for review. |
captainsafia
reviewed
Feb 3, 2025
src/Mvc/Mvc.Core/test/ApplicationModels/DefaultApplicationModelProviderTest.cs
Outdated
Show resolved
Hide resolved
…sult returning action
…h typed result return type
mkArtakMSFT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include typed result metadata in the action descriptors for MVC Controller actions
Description
The endpoint metadata wasn't being captured in ActionModel during the ApplicationModel creation. This is addressed by the change in the DefaultApplicationModelProvider class. The metadata is now being extracted based on the return type of the action and then the selectors associated with the action are populated with that metadata, as that's what is being used later on for populating the ActionDescriptor's EndpointMetadata.
Fixes #44988