Quarantine Http2ConnectionTests.IgnoreNewStreamsDuringClosedConnection test. #60120
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shethaadit
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
|
Thanks for your PR, @shethaadit. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
community-contribution
|
Don't put fixes, we want the linked issue to stay open so we can track fixing it and removing it from quarantine. |
BrennanConroy
approved these changes
Jan 30, 2025
|
Hi @BrennanConroy, I just saw your comments. I have actually raised PRs to fix 3 issues. But as you mentioned, will take care going forward. :) |
You can just edit your PR summary to not say fixes. |
|
Sure, Thank you @BrennanConroy for your suggestion. I have updated comments for other 2 PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quarantine Test
Summary of the changes (Less than 80 chars)
Description
Quarantine Http2ConnectionTests.IgnoreNewStreamsDuringClosedConnection test.
For #60111