[Blazor] Add preload placeholder to blazorwasm template #61448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
area-blazor
pavelsavara
reviewed
Apr 11, 2025
| @@ -6,6 +6,7 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
| <title>ComponentsWebAssembly-CSharp</title> | |||
| <base href="/" /> | |||
| <link rel="preload" id="webassembly" /> | |||
There was a problem hiding this comment.
dotnet-wasm ? dotnet-webassembly ?
There was a problem hiding this comment.
I think changing the name would require changing the SDK side too. If we don't feel strongly about naming, I think going with webassembly is fine. (It's also more consistent with what we use elsewhere, where we just use webassembly if that helps)
There was a problem hiding this comment.
This name already landed in different PR for "hosted" mode.
I probably wouldn't prefer dotnet- prefix as everything here is dotnet.
Whether wasm or webassembly is up for discussion.
3 tasks
…aceholderTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add placeholder that
OverrideHtmlAssetPlaceholders=truefeature overrides with link elements to WebAssembly assets to preload.Contributes to #58875