Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure/pipelines/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -708,9 +708,9 @@ extends:
binlogPath: artifacts/log/Release/Build.binlog
presteps:
- task: NodeTool@0
displayName: Install Node 20.x
displayName: Install Node 24.x
inputs:
versionSpec: 20.x
versionSpec: 24.14.x
pool:
name: $(DncEngInternalBuildPool)
demands: ImageOverride -equals windows.vs2026preview.scout.amd64
Expand Down
8 changes: 4 additions & 4 deletions .azure/pipelines/jobs/default-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ jobs:
displayName: Start background dump collection
- ${{ if eq(parameters.installNodeJs, 'true') }}:
- task: NodeTool@0
displayName: Install Node 20.x
displayName: Install Node 24.x
inputs:
versionSpec: 20.x
versionSpec: 24.14.x
- ${{ if and(eq(parameters.agentOs, 'Windows'), eq(parameters.isAzDOTestingJob, true)) }}:
- powershell: |
Write-Host "##vso[task.setvariable variable=SeleniumProcessTrackingFolder]$(Build.SourcesDirectory)\artifacts\tmp\selenium\"
Expand Down Expand Up @@ -413,9 +413,9 @@ jobs:
displayName: Start background dump collection
- ${{ if eq(parameters.installNodeJs, 'true') }}:
- task: NodeTool@0
displayName: Install Node 20.x
displayName: Install Node 24.x
inputs:
versionSpec: 20.x
versionSpec: 24.14.x
- ${{ if eq(parameters.agentOs, 'Windows') }}:
- powershell: Write-Host "##vso[task.prependpath]$(DOTNET_CLI_HOME)\.dotnet\tools"
displayName: Add dotnet tools to path
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/markdownlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: 16.x
node-version: 24.14.x
- name: Run Markdownlint
run: |
echo "::add-matcher::.github/workflows/markdownlint-problem-matcher.json"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-jquery-validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: '20.x'
node-version: '24.14.x'

- name: Set RepoRoot
run: echo "RepoRoot=$(pwd)" >> $GITHUB_ENV
Expand Down
59 changes: 31 additions & 28 deletions .github/workflows/validate-npm-package-lock-json.yml
Original file line number Diff line number Diff line change
@@ -1,30 +1,33 @@
name: Validate package-lock.json against source feeds

on:
# Manual run
workflow_dispatch:
pull_request:
paths:
- 'package-lock.json'

jobs:
validate-package-lock-json:
name: 'Validate package-lock.json against source feeds'
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@0c366fd6a839edf440554fa01a7085ccba70ac98 # v4.2.2
with:
fetch-depth: 0
submodules: false

- name: Set up Node.js
name: Validate package-lock.json against source feeds

permissions:
contents: read

on:
# Manual run
workflow_dispatch:
pull_request:
paths:
- 'package-lock.json'

jobs:
validate-package-lock-json:
name: 'Validate package-lock.json against source feeds'
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@0c366fd6a839edf440554fa01a7085ccba70ac98 # v4.2.2
with:
fetch-depth: 0
submodules: false

- name: Set up Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: 20.x
- name: Run npm ci to validate package-lock.json against the feed
shell: pwsh
id: npm-install-script
with:
node-version: 24.14.x

- name: Run npm ci to validate package-lock.json against the feed
shell: pwsh
id: npm-install-script
run: npm ci --prefer-online --fetch-retries 5
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
registry=https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm/npm/registry/
always-auth=true
min-release-age=3d
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
}
},
"engines": {
"node": ">=20.9.0",
"npm": ">=9.3.1"
"node": ">=24.14.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiercn can you please check whether azurelinux has 24.14? otherwise this will break the VMR build as we use node from AZL packages there

Copy link
Copy Markdown
Member

@akoeplinger akoeplinger Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we checked and the AZL image has node 24.13.0 and npm 11.6.2 so this needs some updates

"npm": ">=11.11.0"
Comment on lines +39 to +40
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the engines field “enforce[s]” node/npm versions, but npm won’t actually block installs based on engines unless engine-strict=true (or a CI check) is in place. If enforcement is intended, add an explicit validation step / config; otherwise consider rewording the description to “document/require”.

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"karma-sauce-launcher": "^4.3.6",
Expand Down
Loading