-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Update Node.js to v24.14.x and npm to v11.11.0 across build infrastructure #66173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,33 @@ | ||
| name: Validate package-lock.json against source feeds | ||
|
|
||
| on: | ||
| # Manual run | ||
| workflow_dispatch: | ||
| pull_request: | ||
| paths: | ||
| - 'package-lock.json' | ||
|
|
||
| jobs: | ||
| validate-package-lock-json: | ||
| name: 'Validate package-lock.json against source feeds' | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@0c366fd6a839edf440554fa01a7085ccba70ac98 # v4.2.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| submodules: false | ||
|
|
||
| - name: Set up Node.js | ||
| name: Validate package-lock.json against source feeds | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| # Manual run | ||
| workflow_dispatch: | ||
| pull_request: | ||
| paths: | ||
| - 'package-lock.json' | ||
|
|
||
| jobs: | ||
| validate-package-lock-json: | ||
| name: 'Validate package-lock.json against source feeds' | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@0c366fd6a839edf440554fa01a7085ccba70ac98 # v4.2.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| submodules: false | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version: 20.x | ||
| - name: Run npm ci to validate package-lock.json against the feed | ||
| shell: pwsh | ||
| id: npm-install-script | ||
| with: | ||
| node-version: 24.14.x | ||
|
|
||
| - name: Run npm ci to validate package-lock.json against the feed | ||
| shell: pwsh | ||
| id: npm-install-script | ||
| run: npm ci --prefer-online --fetch-retries 5 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| registry=https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm/npm/registry/ | ||
| always-auth=true | ||
| min-release-age=3d |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,8 +36,8 @@ | |
| } | ||
| }, | ||
| "engines": { | ||
| "node": ">=20.9.0", | ||
| "npm": ">=9.3.1" | ||
| "node": ">=24.14.1", | ||
| "npm": ">=11.11.0" | ||
|
Comment on lines
+39
to
+40
|
||
| }, | ||
| "devDependencies": { | ||
| "karma-sauce-launcher": "^4.3.6", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiercn can you please check whether azurelinux has 24.14? otherwise this will break the VMR build as we use node from AZL packages there
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we checked and the AZL image has node 24.13.0 and npm 11.6.2 so this needs some updates