Fix Invalid Trim Warning Suppression in BindConverter.cs#66997
Open
surya3655 wants to merge 2 commits into
Open
Fix Invalid Trim Warning Suppression in BindConverter.cs#66997surya3655 wants to merge 2 commits into
surya3655 wants to merge 2 commits into
Conversation
Contributor
|
Thanks for your PR, @surya3655. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Invalid Trim Warning Suppression in BindConverter.cs
Description
Fixed invalid
UnconditionalSuppressMessageattributes onBindConverter.csthat were causing incorrect trimmer behavior. The original blanket suppressions on 130-line methods claimed "methods don't have DynamicallyAccessedMembers annotations" which was factually incorrect. Extracted reflection operations into small helper methods with targeted suppressions and accurate justifications.Problem Description
The original code had blanket suppressions on large
Get<T>()methods (130+ lines) that claimed:This was false. Methods like
MakeArrayTypeConverter<T>DO have[DynamicallyAccessedMembers(All)]annotations. The incorrect suppressions caused the trimmer to make wrong decisions about what to keep/remove, potentially breaking:string[],int[])Solution
Extracted reflection operations into small targeted helper methods with precise suppressions:
CreateArrayFormatter<T>DynamicallyAccessedMembers(All)constraint"CreateEnumParser<T>DynamicallyAccessedMembers(All)constraint"CreateNullableEnumParser<T>CreateArrayParser<T>Files Changed
src/Components/Components/src/BindConverter.cssrc/Components/Components/src/PersistentComponentState.cssrc/Components/Components/src/PersistentValueProviderComponentSubscription.csValidation
<EnableAOTAnalyzer>trueFixes : #57016