Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure BuildOptions can configure the output directory instead of forcing inline rendering #9986

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure BuildOptions can configure the output directory instead of forcing inline rendering #9986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Docfx.App/BuildOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,9 @@ public class BuildOptions
/// Configures the markdig markdown pipeline.
/// </summary>
public Func<MarkdownPipelineBuilder, MarkdownPipelineBuilder>? ConfigureMarkdig { get; init; }

/// <summary>
/// The output directory for the site build, if not set it will be rendered inline.
/// </summary>
public string? OutputDirectory { get; init; }
}
2 changes: 1 addition & 1 deletion src/Docfx.App/Docset.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public static Task Build(string configPath, BuildOptions options)
{
return Exec(configPath, (config, configDirectory) =>
{
RunBuild.Exec(config.build, options, configDirectory);
RunBuild.Exec(config.build, options, configDirectory, options.OutputDirectory);
return Task.CompletedTask;
});
}
Expand Down
1 change: 1 addition & 0 deletions test/docfx.Tests/Api.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ public class BuildOptions
{
public BuildOptions() { }
public System.Func<Markdig.MarkdownPipelineBuilder, Markdig.MarkdownPipelineBuilder>? ConfigureMarkdig { get; init; }
public string? OutputDirectory { get; init; }
}
public static class Docset
{
Expand Down