-
Notifications
You must be signed in to change notification settings - Fork 238
Clarify TabbedPage Shell incompatibility and modal usage #3117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Learn Build status updates of commit a6421ad: ✅ Validation status: passedFor more details, please refer to the build report. |
…narios Co-authored-by: PureWeen <[email protected]>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 1464910: ✅ Validation status: passed
For more details, please refer to the build report. |
|
@copilot this should clarify that for modals you can register tabbedpage, flyoutpage and navigationpage because its a separate space from shell |
Co-authored-by: PureWeen <[email protected]>
Updated in 896349d. The warning now clarifies that TabbedPage is incompatible with the Shell visual hierarchy specifically, but can be displayed as a modal page using |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 896349d: ✅ Validation status: passed
For more details, please refer to the build report. |
Users attempting to navigate to a
TabbedPagefrom a Shell app usingRouting.RegisterRouteandShell.Current.GoToAsyncget a "View Not found" error with no clear explanation why.Changes
Routing.RegisterRoutecannot register aTabbedPageas a route in the Shell visual hierarchyShell.Current.GoToAsynccannot navigate to aTabbedPageTabbedPageCAN be used as a modal page in Shell apps usingNavigation.PushModalAsyncbecause modal pages exist in a separate navigation spaceExample of what doesn't work
Example of what DOES work
For Shell apps needing tabs as part of the visual hierarchy, use
TabBar/Tab/ShellContentinstead. For displaying a TabbedPage temporarily, use modal navigation.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.