-
Notifications
You must be signed in to change notification settings - Fork 6k
Add MSBuild test-related properties #42404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
### IsTestProject | ||
|
||
The `IsTestProject` property signifies that a project is a test project. When this property is set to `true`, validation to check if the project references a self-contained executable is disabled. That's because test projects have an `OutputType` of `Exe` but usually call APIs in a referenced executable rather than trying to run. In addition, if a project references a project where `IsTestProject` is set to `true`, the test project isn't validated as an executable reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this property do anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question for @Evangelink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. @nohwnd?
docs/core/testing/unit-testing-platform-integration-dotnet-test.md
Outdated
Show resolved
Hide resolved
docs/core/testing/unit-testing-platform-integration-dotnet-test.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if it would make sense to group the properties by platform:
- VSTest
- Microsoft.Testing.Platform
to make it easy to understand which properties are available in which mode.
I am fine with current setup, I am just trying to put myself in the shoes of someone with basic knowledge in testing "internals".
|
||
### IsTestProject | ||
|
||
The `IsTestProject` property signifies that a project is a test project. When this property is set to `true`, validation to check if the project references a self-contained executable is disabled. That's because test projects have an `OutputType` of `Exe` but usually call APIs in a referenced executable rather than trying to run. In addition, if a project references a project where `IsTestProject` is set to `true`, the test project isn't validated as an executable reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property is mainly needed for dotnet test
scenario and has no impact when using vstest.console.exe
. @nohwnd Could you please confirm and give some more details?
|
||
### IsTestProject | ||
|
||
The `IsTestProject` property signifies that a project is a test project. When this property is set to `true`, validation to check if the project references a self-contained executable is disabled. That's because test projects have an `OutputType` of `Exe` but usually call APIs in a referenced executable rather than trying to run. In addition, if a project references a project where `IsTestProject` is set to `true`, the test project isn't validated as an executable reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. @nohwnd?
docs/core/testing/unit-testing-platform-integration-dotnet-test.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing, I was off for a week.
I am wondering if it would make sense to group the properties by platform:
- VSTest
- Microsoft.Testing.Platform
to make it easy to understand which properties are available in which mode.
I am fine with current setup, I am just trying to put myself in the shoes of someone with basic knowledge in testing "internals".
Tracked in #42544. |
Fixes #41672.
Preview: https://review.learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props?branch=pr-en-us-42404#test-projectrelated-properties
Internal previews