[Orleans] Silo Metadata and Placement Filtering #44187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Note that dotnet/orleans#9271 has yet to be merged or included in an Orleans release yet. |
IEvangelist
reviewed
Jan 17, 2025
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
|
Reviewing to see if any updates are needed from the changes in the committed PR |
Aligning with changes to implementation.
|
@IEvangelist PR for the implementation has been merged and docs updated for changes in the PR |
moved Silo metadata to host configuration section
|
Hey @ReubenBond - could you please take a look at this as well? |
IEvangelist
reviewed
Mar 11, 2025
| public class MyGrain() : Grain, IMyGrain | ||
| { | ||
| // ... | ||
|
|
| ms.date: 01/08/2025 | ||
| --- | ||
|
|
||
| # Silo Metadata |
There was a problem hiding this comment.
Suggested change
| # Silo Metadata | |
| # Silo metadata |
|
|
||
| # Silo Metadata | ||
|
|
||
| Silo Metadata is a new feature in Orleans that allows developers to assign custom metadata to silos within a cluster. This metadata provides a flexible mechanism for annotating silos with descriptive information or specific capabilities. |
There was a problem hiding this comment.
Suggested change
| Silo Metadata is a new feature in Orleans that allows developers to assign custom metadata to silos within a cluster. This metadata provides a flexible mechanism for annotating silos with descriptive information or specific capabilities. | |
| Silo metadata is a feature in Orleans that allows developers to assign custom metadata to silos within a cluster. This metadata provides a flexible mechanism for annotating silos with descriptive information or specific capabilities. |
|
|
||
| This feature is particularly useful in scenarios where different silos have distinct roles, hardware configurations, or other unique characteristics. For example, silos can be tagged based on their region, compute power, or specialized responsibilities within the system. | ||
|
|
||
| Silo Metadata lays the groundwork for additional Orleans features, such as Placement Filtering. |
There was a problem hiding this comment.
Suggested change
| Silo Metadata lays the groundwork for additional Orleans features, such as Placement Filtering. | |
| Silo metadata lays the groundwork for additional Orleans features, such as [Grain placement filtering](../grains/grain-placement-filtering.md). |
|
|
||
| The `ISiloMetadataCache` provides a method to retrieve the metadata for a specific silo by its unique identifier (`SiloAddress`). The `ISoloMetadataCache` implementation is registered in the `UseSiloMetadata` method and can be injected as a dependency. | ||
|
|
||
| #### Example: Accessing Metadata for a Silo |
There was a problem hiding this comment.
Suggested change
| #### Example: Accessing Metadata for a Silo | |
| #### Example: Access metadata for a Silo |
| } | ||
| ``` | ||
|
|
||
| In this example: |
There was a problem hiding this comment.
Suggested change
| In this example: | |
| In the preceding example: |
Comment on lines
+112
to
+115
|
|
||
| --- | ||
|
|
||
| ## Internal Implementation |
There was a problem hiding this comment.
Suggested change
| --- | |
| ## Internal Implementation | |
| ## Internal implementation |
|
|
||
| ## Internal Implementation | ||
|
|
||
| Internally, the `SiloMetadataCache` monitors changes in cluster membership on `MembershipTableManager` and will keep the local cache of metadata in sync with membership changes. Metadata is immutable for a given Silo so it will be retreived once and cached until that Silo leaves the cluster. Cached metadata for clusters that are `Dead` or have left the membership table will be cleared out of the local cache. |
There was a problem hiding this comment.
Suggested change
| Internally, the `SiloMetadataCache` monitors changes in cluster membership on `MembershipTableManager` and will keep the local cache of metadata in sync with membership changes. Metadata is immutable for a given Silo so it will be retreived once and cached until that Silo leaves the cluster. Cached metadata for clusters that are `Dead` or have left the membership table will be cleared out of the local cache. | |
| Internally, the `SiloMetadataCache` monitors changes in cluster membership on `MembershipTableManager` and keeps a local cache of metadata in sync with membership changes. Metadata is immutable for a given Silo, so it's retrieved once and cached until that Silo leaves the cluster. Cached metadata for clusters that are `Dead` or have left the membership table will be cleared out of the local cache. |
|
|
||
| Internally, the `SiloMetadataCache` monitors changes in cluster membership on `MembershipTableManager` and will keep the local cache of metadata in sync with membership changes. Metadata is immutable for a given Silo so it will be retreived once and cached until that Silo leaves the cluster. Cached metadata for clusters that are `Dead` or have left the membership table will be cleared out of the local cache. | ||
|
|
||
| Each silo hosts an ISystemTarget that provides that silo's metadata. Calls to `SiloMetadataCache : ISiloMetadataCache` then return a result from this local cache. |
There was a problem hiding this comment.
Suggested change
| Each silo hosts an ISystemTarget that provides that silo's metadata. Calls to `SiloMetadataCache : ISiloMetadataCache` then return a result from this local cache. | |
| Each silo hosts an `ISystemTarget` that provides that silo's metadata. Calls to `SiloMetadataCache : ISiloMetadataCache` return a result from the local cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documentation for code changes here: dotnet/orleans#9271
Internal previews