Skip to content

ASP.NET Built-in Metrics: Delete and forward to new location #45791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Apr 11, 2025

Summary

  • The ASP.NET Build-In Metrics topic has been removed in and, the TOC updated to point to its new location in the aspnetcore.docs repository. (The file was moved to there in a previous PR).
  • Redirection was added to point to the new location of the ASP.NET Core Metrics topic.

Fixes #45580
Fixes dotnet/AspNetCore.Docs#35109

Internal preview test: ASP.NET Core metrics link in TOC
Select in the TOC: Built-in metrics > ASP.NET Core metrics


Internal previews

📄 File 🔗 Preview link
docs/breadcrumb/toc.yml docs/breadcrumb/toc
docs/core/diagnostics/built-in-metrics.md docs/core/diagnostics/built-in-metrics
docs/navigate/tools-diagnostics/toc.yml docs/navigate/tools-diagnostics/toc

@wadepickett
Copy link
Contributor Author

Closing and reopening to attempt re-build since the OPS status checker seems to be having an existential crisis, absorbed in an endless loop of self-reflection...

@wadepickett wadepickett reopened this Apr 12, 2025
@wadepickett wadepickett marked this pull request as ready for review April 12, 2025 01:01
@wadepickett wadepickett requested review from tommcdon and a team as code owners April 12, 2025 01:01
@wadepickett wadepickett requested a review from gewarren April 12, 2025 05:32
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion with how a contextual TOC link works (you can also read about them in the contributor guide).

@wadepickett
Copy link
Contributor Author

OH! You wanted a breadcrumb! Sorry, I was not catching on. Thanks!

@wadepickett
Copy link
Contributor Author

Internal preview test: ASP.NET Core metrics link in TOC
Select in the TOC: Built-in metrics > ASP.NET Core metrics

@wadepickett wadepickett requested a review from IEvangelist April 15, 2025 01:35
@wadepickett
Copy link
Contributor Author

@IEvangelist, this seems to work fine, but I'm not confident my entry in the docs/breadcrumb/toc.yml is in the right place. gewarren may not be available and I saw you had some contextual links in here so I'm picking on you. :)

Handy Internal preview test link: ASP.NET Core metrics link in TOC
Select in the TOC: Built-in metrics > ASP.NET Core metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants