Open
Correct TargetFramework precedence documentation#55873
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix msbuild props target framework precedence note
Correct TargetFramework precedence documentation
Sep 2, 2026
gewarren
approved these changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The precedence note must explicitly require TargetFramework to be non-empty.
Review details
Suppressed comments (1)
docs/core/project-sdk/msbuild-props.md:147
- This overstates the precedence rule: the SDK condition cited in #55612 requires
TargetFrameworkto be non-empty. If the property is present but evaluates to an empty string, a non-emptyTargetFrameworksstill enables cross-targeting. State the non-empty requirement so the note matches the documented SDK behavior.
> If `TargetFramework` (singular) is specified, `TargetFrameworks` (plural) is ignored, and the project builds as a single-target project.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation reverses the precedence of
TargetFrameworkandTargetFrameworks. A non-emptyTargetFrameworktakes precedence and produces a single-target build.TargetFrameworks.TargetFrameworksis ignored whenTargetFrameworkis specified.Internal previews
Build report