Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HttpClient exception docs #11103

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

antonfirsov
Copy link
Member

  • For each HttpClient method, list all main cases where an HttpRequestException might be thrown.
  • Add missing exception docs for PatchAsync.
  • Extend remarks for EnsureSuccessStatusCode.
  • Add remarks for Get(ByteArray|Stream|String)Async, calling out that in some cases manual status code validation might be a better option

The PR does not touch the HttpClientJsonExtensions docs, I'm planning to do it in a separate PR.

Fixes #9148

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit e78a667:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpResponseMessage.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient.GetStreamAsync raising HttpRequestException
2 participants