Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move snippet to separate files for csharp and vb #8079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

syrotkin
Copy link

Summary

Move the SemaphoreSlim code snippet to separate snippet files for C# and VB.NET

No issue has been created for this.

@syrotkin syrotkin requested review from kouvel and a team as code owners May 16, 2022 17:03
@dnfadmin
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ syrotkin sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@opbld32
Copy link

opbld32 commented May 16, 2022

Docs Build status updates of commit 9ae5c8e:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Threading/SemaphoreSlim/Overview/waitRelease.cs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.threading.semaphoreslim/vb/waitRelease.vb ✅Succeeded View
xml/System.Threading/SemaphoreSlim.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also add a simple .NET 6 project file for the VB example?

@@ -0,0 +1,9 @@
// <Snippet2>
// Enter semaphore by calling one of the Wait or WaitAsync methods.
SemaphoreSlim.Wait()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SemaphoreSlim.Wait()
SemaphoreSlim.Wait();

//
// Execute code protected by the semaphore.
//
SemaphoreSlim.Release()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SemaphoreSlim.Release()
SemaphoreSlim.Release();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants