Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

Fixes: dotnet/dotnet#4177

Updates azurelinux/3.0/net11.0/source-build-test/amd64 to use .NET 11 preview base image from nightly repo.

Will create a tracking issue to switch back to main repo after .NET 11 preview ships.

@@ -0,0 +1,39 @@
ARG DOTNET_VERSION
FROM mcr.microsoft.com/dotnet/nightly/sdk:$DOTNET_VERSION-azurelinux3.0-amd64 AS installer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could future-proof things a bit more. Instead of a copy, I think we can reuse the one from the net8.0 directory with a bit of tweaks that will allow it to work for future preview versions as well.

Suggested change
FROM mcr.microsoft.com/dotnet/nightly/sdk:$DOTNET_VERSION-azurelinux3.0-amd64 AS installer
ARG REPO_MODIFIER
FROM mcr.microsoft.com/dotnet/${REPO_MODIFIER}sdk:$DOTNET_VERSION-azurelinux3.0-amd64 AS installer

And then in the manifest you would set REPO_MODIFIER to nightly/ for the 11.0 version. Then once 11.0 P1 ships, all that needs to be done is remove that arg from the manifest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Will commit this change and update the manifest in a new commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since we're modifying the old file - I'll make all the changes in a new commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since ImageBuilder doesn't support the curly brace syntax in this case, you can ignore this change.

@NikolaMilosavljevic
Copy link
Member Author

This PR is failing 3 checks that are unrelated - the same checks are failing in other PRs, i.e. #1572

This can be merged anytime - I don't have permissions. @mthalman @lbussell

@mthalman
Copy link
Member

It won't help to merge it since it will just fail in the internal build too.

@dotnet/prodconsvcs - The build needs fixing.

@NikolaMilosavljevic NikolaMilosavljevic merged commit 7557776 into dotnet:main Jan 15, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License Scan tests failing in main

2 participants