Add CI images for dotnet/vscode-csharp integration tests - #1730
Merged
lbussell merged 2 commits intoAug 12, 2026
Conversation
Member
Author
|
/azp run dotnet-buildtools-prereqs-docker-pr |
|
Commenter does not have sufficient privileges for PR 1730 in repo dotnet/dotnet-buildtools-prereqs-docker |
dibarbet
force-pushed
the
dibarbet-add-vscode-csharp-images
branch
from
August 6, 2026 16:48
621e6db to
80fa228
Compare
JoeRobich
approved these changes
Aug 6, 2026
dibarbet
marked this pull request as ready for review
August 6, 2026 20:28
Member
|
@dibarbet what's the size of the image (either on disk, or compressed) after it's built? Just curious. |
Member
Author
Locally I'm seeing each image around 1.3 GB disk size - with the incremental usage compared to the base image being ~460-490 MB |
Member
Author
|
@dotnet/dotnet-docker-reviewers could use a review here, happy to give more details if needed |
lbussell
approved these changes
Aug 11, 2026
lbussell
enabled auto-merge (squash)
August 12, 2026 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests in vscode-csharp that run on docker images currently have to install a few additional dependencies in order to run vscode. Currently they are installed as part of the pipeline which is usually fast, but can sometimes take ~30 minutes when the repository is slow.
Instead, we can create a docker image that we can re-use that already has the dependencies installed.