Skip to content

Use branded triplet in llvm build on AZL 4.0 - #1734

Merged
akoeplinger merged 2 commits into
dotnet:mainfrom
am11:patch-3
Aug 11, 2026
Merged

Use branded triplet in llvm build on AZL 4.0#1734
akoeplinger merged 2 commits into
dotnet:mainfrom
am11:patch-3

Conversation

@am11

@am11 am11 commented Aug 11, 2026

Copy link
Copy Markdown
Member

Removed the workaround and match packages' approach to use branded triplet, per #1733 (comment).

@am11
am11 requested review from a team as code owners August 11, 2026 16:50
@am11

am11 commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

cc @akoeplinger

@akoeplinger akoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@akoeplinger
akoeplinger merged commit 43a6446 into dotnet:main Aug 11, 2026
10 checks passed
@am11

am11 commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

@akoeplinger, unfortunately, this is not enough. The symlink approach is much simpler than the "matching distro" approach. The symlink is one line vs. this microsoft/azurelinux@f394783. They manually create /etc/clang/{triple}.cfg (which you can check after dnf install, as you did before), then point the LLVM build to use that config file. In our case, that would mean echo .... > /etc/clang/{triple}.cfg followed by COPY in the other layer, which is a bit more work than the symlink. It's all distro-specific branding that has zero bearing on the product. Honestly, it doesn't make much sense to follow distro branding here; if anything, it should be dotnet branding since this is our custom llvm toolchain build.

@am11
am11 deleted the patch-3 branch August 12, 2026 03:19
am11 added a commit to am11/dotnet-buildtools-prereqs-docker that referenced this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants