Update to Aspire 9.3 #837
Merged
Update to Aspire 9.3 #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to Aspire 9.3 by revising dependency versions, removing Docker Compose support, and adding a named URL feature for the WebApp dashboard.
- Removed the Aspire.Hosting.Docker package (and related publisher) due to URL issues.
- Updated dependency versions and package references in project files for Aspire 9.3.
- Added a call to WithUrls in Program.cs to customize link display in the dashboard.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/eShop.AppHost/eShop.AppHost.csproj | Removed the Docker package reference to match Aspire 9.3 support |
| src/eShop.AppHost/Program.cs | Added WithUrls for clearer dashboard links and removed DockerComposePublisher |
| src/Catalog.API/Services/CatalogAI.cs | Updated API call name from GenerateEmbeddingVectorAsync to GenerateVectorAsync |
| Directory.Packages.props | Updated dependency versions for Aspire, GRPC, and related packages |
davidfowl
approved these changes
May 15, 2025
- Enable OpenAI telemetry - Upgrade to the gpt-4.1-mini model and increase the token rate limit
danmoseley
reviewed
May 16, 2025
danmoseley
reviewed
May 16, 2025
danmoseley
approved these changes
May 16, 2025
jeffhandley
reviewed
May 16, 2025
- Update OpenTelemetry to 1.12
- AspireUnstablePackagesVersion to shipping version - Ollama to latest released
|
This should be ready to merge now that the packages are available on nuget.org. |
davidfowl
reviewed
May 19, 2025
Comment on lines
+69
to
+70
| <PackageVersion Include="CommunityToolkit.Aspire.Hosting.Ollama" Version="9.4.1-beta.289" /> | ||
| <PackageVersion Include="CommunityToolkit.Aspire.OllamaSharp" Version="9.4.1-beta.289" /> |
There was a problem hiding this comment.
It is the latest on nuget.org. We need a version that is compatible with the latest MEAI versions.
This was referenced May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this won't pass CI until 9.3 is published to nuget.org.