Skip two failing tests and add SkipOnHelixCondition attribute (#38203)

* Skip SDK-dependent tests on Helix

Add SkipOnHelixConditionAttribute to the ConditionalFact infrastructure
in EFCore.Specification.Tests. Use it on Csproj_metadata_can_be_extracted
and File_based_app_can_be_built since these tests require a full dotnet
SDK which is not available on Helix agents.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Skip SDK-dependent tests on Helix with SkipOnHelixCondition

Add SkipOnHelixConditionAttribute to the ConditionalFact infrastructure
in EFCore.Specification.Tests. Replace all inline HELIX_WORKITEM_ROOT
checks across 31 SqlServer type test files and 2 dotnet-ef tests with
the new [SkipOnHelixCondition] attribute.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Rename 'Validate Job Results' to 'Job Results' in pipelines

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: AndriySvyryd

azure-pipelines-internal-tests.yml

@@ -623,7 +623,7 @@ extends:
       condition: always()
       jobs:
       - job: Validate_Job_Results
-        displayName: Validate Job Results
+        displayName: Job Results
         pool:
           name: $(DncEngInternalBuildPool)
           demands: ImageOverride -equals 1es-windows-2022

azure-pipelines-public.yml

@@ -442,7 +442,7 @@ stages:
   condition: always()
   jobs:
   - job: Validate_Job_Results
-    displayName: Validate Job Results
+    displayName: Job Results
     pool:
       name: $(DncEngPublicBuildPool)
       demands: ImageOverride -equals 1es-windows-2022-open

test/EFCore.Specification.Tests/TestUtilities/Xunit/SkipOnHelixConditionAttribute.cs

@@ -0,0 +1,13 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
+[AttributeUsage(AttributeTargets.Method | AttributeTargets.Class | AttributeTargets.Assembly)]
+public sealed class SkipOnHelixConditionAttribute : Attribute, ITestCondition
+{
+    public ValueTask<bool> IsMetAsync()
+        => new(Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is null);
+
+    public string SkipReason { get; set; } = "Test does not run on Helix.";
+}

test/EFCore.SqlServer.FunctionalTests/Types/Geography/SqlServerGeographyCollectionTypeTest.cs

@@ -3,6 +3,8 @@
 
 using NetTopologySuite.Geometries;
 
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Types.Geography;
 
 public class SqlServerGeographyCollectionTypeTest(SqlServerGeographyCollectionTypeTest.GeographyCollectionTypeFixture fixture, ITestOutputHelper testOutputHelper)
@@ -175,15 +177,11 @@ FROM [JsonTypeEntity] AS [j]
         }
     }
 
+    // TODO: Currently failing on Helix only, see #36746
     [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
+    [SkipOnHelixCondition]
     public override async Task ExecuteUpdate_within_json_to_nonjson_column()
     {
-        // TODO: Currently failing on Helix only, see #36746
-        if (Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is not null)
-        {
-            return;
-        }
-
         await base.ExecuteUpdate_within_json_to_nonjson_column();
 
         if (Fixture.UsingJsonType)

test/EFCore.SqlServer.FunctionalTests/Types/Geography/SqlServerGeographyLineStringTypeTest.cs

@@ -3,6 +3,8 @@
 
 using NetTopologySuite.Geometries;
 
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Types.Geography;
 
 public class SqlServerGeographyLineStringTypeTest(
@@ -169,15 +171,11 @@ FROM [JsonTypeEntity] AS [j]
         }
     }
 
+    // TODO: Currently failing on Helix only, see #36746
     [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
+    [SkipOnHelixCondition]
     public override async Task ExecuteUpdate_within_json_to_nonjson_column()
     {
-        // TODO: Currently failing on Helix only, see #36746
-        if (Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is not null)
-        {
-            return;
-        }
-
         await base.ExecuteUpdate_within_json_to_nonjson_column();
 
         if (Fixture.UsingJsonType)

test/EFCore.SqlServer.FunctionalTests/Types/Geography/SqlServerGeographyMultiLineStringTypeTest.cs

@@ -3,6 +3,8 @@
 
 using NetTopologySuite.Geometries;
 
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Types.Geography;
 
 public class SqlServerGeographyMultiLineStringTypeTest(
@@ -173,15 +175,11 @@ FROM [JsonTypeEntity] AS [j]
         }
     }
 
+    // TODO: Currently failing on Helix only, see #36746
     [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
+    [SkipOnHelixCondition]
     public override async Task ExecuteUpdate_within_json_to_nonjson_column()
     {
-        // TODO: Currently failing on Helix only, see #36746
-        if (Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is not null)
-        {
-            return;
-        }
-
         await base.ExecuteUpdate_within_json_to_nonjson_column();
 
         if (Fixture.UsingJsonType)

test/EFCore.SqlServer.FunctionalTests/Types/Geography/SqlServerGeographyMultiPointTypeTest.cs

@@ -3,6 +3,8 @@
 
 using NetTopologySuite.Geometries;
 
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Types.Geography;
 
 public class SqlServerGeographyMultiPointTypeTest(SqlServerGeographyMultiPointTypeTest.MultiPointTypeFixture fixture, ITestOutputHelper testOutputHelper)
@@ -175,15 +177,11 @@ FROM [JsonTypeEntity] AS [j]
         }
     }
 
+    // TODO: Currently failing on Helix only, see #36746
     [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
+    [SkipOnHelixCondition]
     public override async Task ExecuteUpdate_within_json_to_nonjson_column()
     {
-        // TODO: Currently failing on Helix only, see #36746
-        if (Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is not null)
-        {
-            return;
-        }
-
         await base.ExecuteUpdate_within_json_to_nonjson_column();
 
         if (Fixture.UsingJsonType)

test/EFCore.SqlServer.FunctionalTests/Types/Geography/SqlServerGeographyMultiPolygonTypeTest.cs

@@ -3,6 +3,8 @@
 
 using NetTopologySuite.Geometries;
 
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Types.Geography;
 
 public class SqlServerGeographyMultiPolygonTypeTest(
@@ -173,15 +175,11 @@ FROM [JsonTypeEntity] AS [j]
         }
     }
 
+    // TODO: Currently failing on Helix only, see #36746
     [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
+    [SkipOnHelixCondition]
     public override async Task ExecuteUpdate_within_json_to_nonjson_column()
     {
-        // TODO: Currently failing on Helix only, see #36746
-        if (Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is not null)
-        {
-            return;
-        }
-
         await base.ExecuteUpdate_within_json_to_nonjson_column();
 
         if (Fixture.UsingJsonType)

test/EFCore.SqlServer.FunctionalTests/Types/Geography/SqlServerGeographyPointTypeTest.cs

@@ -3,6 +3,8 @@
 
 using NetTopologySuite.Geometries;
 
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Types.Geography;
 
 public class SqlServerGeographyPointTypeTest(SqlServerGeographyPointTypeTest.PointTypeFixture fixture, ITestOutputHelper testOutputHelper)
@@ -167,15 +169,11 @@ FROM [JsonTypeEntity] AS [j]
         }
     }
 
+    // TODO: Currently failing on Helix only, see #36746
     [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
+    [SkipOnHelixCondition]
     public override async Task ExecuteUpdate_within_json_to_nonjson_column()
     {
-        // TODO: Currently failing on Helix only, see #36746
-        if (Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is not null)
-        {
-            return;
-        }
-
         await base.ExecuteUpdate_within_json_to_nonjson_column();
 
         if (Fixture.UsingJsonType)

test/EFCore.SqlServer.FunctionalTests/Types/Geography/SqlServerGeographyPolygonTypeTest.cs

@@ -3,6 +3,8 @@
 
 using NetTopologySuite.Geometries;
 
+using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
+
 namespace Microsoft.EntityFrameworkCore.Types.Geography;
 
 public class SqlServerGeographyPolygonTypeTest(SqlServerGeographyPolygonTypeTest.PolygonTypeFixture fixture, ITestOutputHelper testOutputHelper)
@@ -167,15 +169,11 @@ FROM [JsonTypeEntity] AS [j]
         }
     }
 
+    // TODO: Currently failing on Helix only, see #36746
     [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
+    [SkipOnHelixCondition]
     public override async Task ExecuteUpdate_within_json_to_nonjson_column()
     {
-        // TODO: Currently failing on Helix only, see #36746
-        if (Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT") is not null)
-        {
-            return;
-        }
-
         await base.ExecuteUpdate_within_json_to_nonjson_column();
 
         if (Fixture.UsingJsonType)