Use PRAGMA defer_foreign_keys
instead of PRAGMA foreign_keys
when migrating
#35873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the use of
PRAGMA foreign_keys
in SQLite migrations toPRAGMA defer_foreign_keys
, which are allowed inside transactionss without any issue.It's one of the possible fixes for #35871, and I think the best one, since we will use the exact pragma that SQLite wants to be used for transactions, instead of working around it.
I did my best attempt to update the tests as well, but not sure this is how I should do it (since I didn't see any mention to
BEGIN TRANSACTION
inside the generated SQL in tests.