[release/9.0-staging] Bump version of Cosmos SDK from 3.45 to 3.48 to improve hybrid search experience out of the box #35946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
cosmos_fts_90_version_bump
branch
from
2c75d21 to
cec0ba0
Compare
maumar
changed the title
…rch experience Continuation of #35909 Bumping version of Cosmos SDK improves user experience out of the box for some scenarios (namely hybrid search). Separated this from the main PR as it required separate approval.
maumar
force-pushed
the
cosmos_fts_90_version_bump
branch
from
cec0ba0 to
dc84360
Compare
maumar
changed the title
maumar
changed the title
|
closing this in favor of PR directly against release/9.0 (rather than staging): #35954 |
FYI can also change the targeted branch (edit button on top) instead of opening a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing this in favor of PR directly against release/9.0 (rather than staging):
#35954
bumping cosmos sdk version to improve hybrid search experience out of the box - this is a dry run, will incorporate these changes to the proper 9.0 PR once/if we have green light for the bump
Continuation of #35909
Description
As part of adding full text search support we realized that some scenarios (specifically hybrid search and some instances of ContainsAll) don't work with the Cosmos SDK that is currently referenced by EFCore.Cosmos 9.x package. The issues can be solved by bumping SDK version to 3.48
Customer impact
Customers trying full text search will experience errors for some scenarios - cryptic exception (Syntax error near '-' for hybrid, and invalid results for some ContainsAll queries). Workaround is to manually upgrade Cosmos SDK dependency.
How found
Internal testing by the partner team.
Regression
No
Testing
All current Cosmos tests pass. Performed smoke test to validate that breaking change added in the SDK (requiring explicit Newtonsoft.Json dependency) doesn't have impact on the customer app.
Risk
Low. This can only affect customers using EFCore.Cosmos, one breaking change introduced in the SDK is benign from the perspective of customers using EFCore to communicate with Cosmos (EFCore package absorbs the breaking change).