[release/10.0] Fix Microsoft.EntityFrameworkCore.Tools for net8.0#37731
[release/10.0] Fix Microsoft.EntityFrameworkCore.Tools for net8.0#37731AndriySvyryd merged 4 commits intorelease/10.0from
Conversation
…ckage Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
AndriySvyryd
left a comment
There was a problem hiding this comment.
@copilot Update progress by rewriting the PR summary using this template:
Fixes #{number}
**Description**
{Issue description}
**Customer impact**
{How does the reported issue affects customer's app? Are there workarounds?}
**How found**
{Was it customer reported or found during verification? How many customers are affected?}
**Regression**
{Is it a regression from a released version? Which one?}
**Testing**
{How the changes were tested}
**Risk**
{Low/Medium/High, argument why}
… use version 8.0.0, remove ItemGroup from csproj Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Updated PR description with the requested template format. |
There was a problem hiding this comment.
Pull request overview
Adjusts the Microsoft.EntityFrameworkCore.Tools NuGet package metadata/content so it’s correctly recognized as supporting net8.0, avoiding incorrect tooling assumptions caused by having no lib/ target framework folder, and loosens the Design dependency from the EF 10 version to a minimum that can work for net8.0 scenarios.
Changes:
- Add
lib/net8.0/_._to make the package’s supported TFM explicit (net8.0). - Update the
.nuspecto includelib/**in the packed files. - Change the
Microsoft.EntityFrameworkCore.Designdependency from$Version$to a minimum of8.0.0.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EFCore.Tools/lib/net8.0/. | Adds a net8.0 lib placeholder to ensure the package advertises an explicit target framework. |
| src/EFCore.Tools/EFCore.Tools.nuspec | Packs the new lib/ content and lowers the minimum Design dependency version to allow net8-compatible restores. |
artl93
left a comment
There was a problem hiding this comment.
Customer reported, critical scenario.
Can we do something proactive to make sure this follows the LTS versioning? this seems like it would break often - we need to make sure this is handled as a part of each release, right?
(Approved otherwise)
Yes, this dependency shouldn't be needed in the first place if the app is referencing Microsoft.EntityFrameworkCore.Design already (common and recommended when using the EF tools). #37739 tracks removing it (it would be technically a breaking change for the apps without this reference) |
Fixes #37515
Description
#37207 was intended to allow the EF tools to run for apps targeting net8.0, however the Microsoft.EntityFrameworkCore.Tools NuGet package does not specify a target framework, and it depends on Microsoft.EntityFrameworkCore.Design 10.0.0 which only targets net10.0
Customer impact
Customers can't use Microsoft.EntityFrameworkCore.Tools 10.0.x for apps targeting net8.0, but some tooling that analyzes NuGet packages incorrectly interpret the lack of a target framework specification and select this version even when targeting net8.0.
How found
3 customer reports on 10.0.x
Regression
Not technically, but it completes the fix in #37207 that was for a regression. Also, a change from #33049 is reverted to make the supported TFM explicit
Testing
Tested manually
Risk
Low. The change is mostly reverting to the state the package was for EF 8
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.