Skip to content

[TINY] Use InterceptableLocation for precompiled query interceptor generation #37734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 3 commits into from
Feb 20, 2026
+17 −4
Merged

[TINY] Use InterceptableLocation for precompiled query interceptor generation #37734

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78a171d
Initial plan
Copilot Feb 18, 2026
d69c454
Use InterceptableLocation-based generation instead of InterceptsLocat…
Copilot Feb 18, 2026
2e1ca78
Move error message to DesignStrings string resource
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/EFCore.Design/Query/Internal/PrecompiledQueryCodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ namespace System.Runtime.CompilerServices
[AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
file sealed class InterceptsLocationAttribute : Attribute
{
public InterceptsLocationAttribute(string filePath, int line, int column) { }
public InterceptsLocationAttribute(int version, string data) { }
}
}
"""
Expand Down Expand Up @@ -496,10 +496,11 @@ when namedReturnType2.AllInterfaces.Prepend(namedReturnType2)
};

// Output the interceptor method signature preceded by the [InterceptsLocation] attribute.
var startPosition = operatorSyntax.SyntaxTree.GetLineSpan(memberAccessSyntax.Name.Span, cancellationToken).StartLinePosition;
var interceptorName = $"Query{queryNum}_{memberAccessSyntax.Name}{operatorNum}";
code.AppendLine(
$"""[InterceptsLocation(@"{operatorSyntax.SyntaxTree.FilePath.Replace("\"", "\"\"")}", {startPosition.Line + 1}, {startPosition.Character + 1})]""");
var invocationSyntax = (InvocationExpressionSyntax)operatorSyntax;
var interceptableLocation = semanticModel.GetInterceptableLocation(invocationSyntax, cancellationToken)
?? throw new InvalidOperationException("Couldn't get interceptable location for: " + operatorSyntax);
code.AppendLine(interceptableLocation.GetInterceptsLocationAttributeSyntax());
GenerateInterceptorMethodSignature();
code.AppendLine("{").IncrementIndent();

Expand Down
Loading