Skip to content

Show a warning when the tools are used with a platform-specific app #37868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 7 commits into from
Mar 25, 2026
Merged

Show a warning when the tools are used with a platform-specific app #37868

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c516943
Initial plan
Copilot Mar 6, 2026
7bcbeb7
Show a warning when dotnet-ef tools are used with a platform-specific…
Copilot Mar 6, 2026
e60ab21
Only warn when TargetPlatformIdentifier differs from the current exec…
Copilot Mar 6, 2026
950dd96
Refactor: extract GetTargetPlatformIdentifier and move logic into IsC…
Copilot Mar 6, 2026
20a9f79
Use MSBuild-style GetTargetPlatformIdentifier to extract platform fro…
Copilot Mar 6, 2026
81db7e8
Always warn for platform-specific projects; new PlatformSpecificProje…
Copilot Mar 25, 2026
bb702d4
Simplify platform-specific warning to single if block, always use Tar…
Copilot Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/dotnet-ef/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/dotnet-ef/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,9 @@
<data name="PrecompileQueriesWarning" xml:space="preserve">
<value>Query precompilation is an experimental feature and should be used with caution.</value>
</data>
<data name="PlatformSpecificProject" xml:space="preserve">
<value>Startup project '{startupProject}' targets a platform-specific framework: '{targetFrameworkValue}'. The Entity Framework Core .NET Command-line Tools might not function correctly. Implement IDesignTimeDbContextFactory&lt;&gt; to ensure design-time tools work correctly with this project. See https://aka.ms/efcore-docs-migrations-projects for more information.</value>
Comment thread
AndriySvyryd marked this conversation as resolved.
</data>
<data name="PrefixDescription" xml:space="preserve">
<value>Prefix output with level.</value>
</data>
Expand Down
23 changes: 23 additions & 0 deletions src/dotnet-ef/RootCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,17 @@ protected override int Execute(string[] _)
startupProject.AssemblyName + ".runtimeconfig.json");
var projectAssetsFile = startupProject.ProjectAssetsFile;

if (!string.IsNullOrEmpty(startupProject.TargetPlatformIdentifier))
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
{
Reporter.WriteWarning(
Resources.PlatformSpecificProject(startupProject.ProjectName, startupProject.TargetPlatformIdentifier));
}
else if (HasPlatformInTargetFramework(startupProject.TargetFramework))
{
Reporter.WriteWarning(
Resources.PlatformSpecificProject(startupProject.ProjectName, startupProject.TargetFramework));
}
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated

var targetFramework = new FrameworkName(startupProject.TargetFrameworkMoniker!);
if (targetFramework.Identifier == ".NETFramework")
{
Expand Down Expand Up @@ -313,6 +324,18 @@ private static string GetVersion()
=> typeof(RootCommand).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()!
.InformationalVersion;

private static bool HasPlatformInTargetFramework(string? targetFramework)
{
if (string.IsNullOrEmpty(targetFramework))
{
return false;
}

// Check for netX.Y-Z form (e.g. net8.0-windows10.0.19041.0)
Comment thread
AndriySvyryd marked this conversation as resolved.
var dashIndex = targetFramework.IndexOf('-');
return dashIndex > 0 && dashIndex < targetFramework.Length - 1;
}

private static bool ShouldHelp(IReadOnlyList<string> commands, IList<string> args)
=> args.Count == 0
|| commands.Count == 0
Expand Down