Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging sampling #5574

Merged
merged 67 commits into from
Feb 27, 2025

Conversation

evgenyfedorov2
Copy link
Contributor

@evgenyfedorov2 evgenyfedorov2 commented Oct 25, 2024

  1. Partially resolves [API Proposal]: Introduce logging sampling and buffering #5123 proposal
  2. Fully resolves [API Proposal]: Use AddRandomProbabilisticSampler instead of AddProbabilisticSampler #5955 proposal

, this PR is focused on the logging sampling only. The buffering part will be in a separate PR.

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2 evgenyfedorov2 marked this pull request as ready for review February 25, 2025 18:33
@evgenyfedorov2 evgenyfedorov2 requested a review from a team as a code owner February 25, 2025 18:33
@dotnet dotnet deleted a comment from dotnet-comment-bot Feb 26, 2025
@dotnet dotnet deleted a comment from dotnet-comment-bot Feb 26, 2025
@dotnet dotnet deleted a comment from dotnet-comment-bot Feb 26, 2025
@dotnet dotnet deleted a comment from dotnet-comment-bot Feb 26, 2025
@dotnet dotnet deleted a comment from dotnet-comment-bot Feb 26, 2025
@dotnet dotnet deleted a comment from dotnet-comment-bot Feb 26, 2025
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evgenyfedorov2 evgenyfedorov2 merged commit b287cfd into dotnet:main Feb 27, 2025
6 checks passed
@geeknoid
Copy link
Member

Yay!

@noahfalk
Copy link
Member

Congrats! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants