-
Notifications
You must be signed in to change notification settings - Fork 814
Allow _
in use!
bindings values
#18487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edgarfgp
wants to merge
15
commits into
dotnet:main
Choose a base branch
from
edgarfgp:fix-16343
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+514
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_
in use! _
bindings values_
in use!
bindings values
❗ Release notes required
|
# Conflicts: # docs/release-notes/.FSharp.Compiler.Service/9.0.300.md # docs/release-notes/.Language/preview.md
44694b7
to
949ee66
Compare
To avoid conflicts #18482 should be merged first. |
T-Gro
reviewed
Apr 24, 2025
src/Compiler/Checking/Expressions/CheckComputationExpressions.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Apr 24, 2025
T-Gro
reviewed
Apr 24, 2025
tests/FSharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/UseBindings/UseBang01.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Apr 25, 2025
|
||
counterDisposable { | ||
use! _ = new Disposable(1) | ||
use! _ = new Disposable(2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good test addition, thank you!
T-Gro
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if we use any pattern that is not
Named
orLongIdent
it errors miserably pointing at theuse!
range.Also it does not allow to wrap patterns In parens(I don't see the point in restricting use e.g.
(x), (__), (_)
.)So in this PR:
Named
orLongIdent
and Wild(only in preview) to be wrapped in parensuse!
rangeBEFORE
AFTER
Fixes #16343
Checklist